Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65586

Not found error: message/pendingcontactrequests.php file doesn't exist anymore

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Duplicate
    • Affects Version/s: 3.6, 3.7
    • Fix Version/s: None
    • Component/s: Messages
    • Testing Instructions:
      Hide
      1. Enable Messaging in Moodle advanced features
      2. Enable "Allow site-wide messaging" in the same page
      3. Create or use three existing users: u1, u2 and u3
      4. Log-in as u1, go to your Preferences -> Notification preferences and check that for the "Message contact requests notification" field the column Web is set to On / On
      5. Log-in as a u2, go to the "Messages" icon (top right), search for u1 and click on their profile. 
      6. Send to u1 a contact request via [...] menu -> Add to contacts -> Add
      7. Log-in as u1 and check there's a new notification in notification bell icon.
      8. Click on 'u2 wants to be added as a contact' link. 
      9. Check you have both 'Accept and add to contacts' and 'Decline' options.
      10. Click on 'Accept and add to contacts' and check once the page has been reloaded you can see u2 - Accepted.
      11. Go to the "Messages" icon (top right) -> Contacts and check u2 is listed as a contact.
      12. Log-in as a u3, go to the "Messages" icon (top right), search for u1 and click on them profile. 
      13. Send to u1 a contact request via [...] menu -> Add to contacts -> Add
      14. Log-in as u1 and check there's a new notification in notification bell icon.
      15. Click on 'u3 wants to be added as a contact' link. 
      16. Click on 'Decline'.
      17. Go to the "Messages" icon (top right) -> Contacts and checked u3 is not listed as a contact.
      Show
      Enable Messaging in Moodle advanced features Enable "Allow site-wide messaging" in the same page Create or use three existing users: u1, u2 and u3 Log-in as u1, go to your Preferences -> Notification preferences and check that for the "Message contact requests notification" field the column Web is set to On / On Log-in as a u2, go to the "Messages" icon (top right), search for u1 and click on their profile.  Send to u1 a contact request via [...] menu -> Add to contacts -> Add Log-in as u1 and check there's a new notification in notification bell icon. Click on 'u2 wants to be added as a contact' link.  Check you have both 'Accept and add to contacts' and 'Decline' options. Click on 'Accept and add to contacts' and check once the page has been reloaded you can see u2 - Accepted. Go to the "Messages" icon (top right) -> Contacts and check u2 is listed as a contact. Log-in as a u3, go to the "Messages" icon (top right), search for u1 and click on them profile.  Send to u1 a contact request via [...] menu -> Add to contacts -> Add Log-in as u1 and check there's a new notification in notification bell icon. Click on 'u3 wants to be added as a contact' link.  Click on 'Decline'. Go to the "Messages" icon (top right) -> Contacts and checked u3 is not listed as a contact.
    • Affected Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull from Repository:
    • Pull 3.6 Branch:
    • Pull Master Branch:
      MDL-65586-master

      Description

      For 'New contact request' notifications, when you click on 'View full notification' link, everything is ok. But when you click on 'xxx wants to be added as a contact' the link goes to a Not found error: message/pendingcontactrequests.php was not found.

      'New contact request' notifications were removed on MDL-63303, but back on MDL-64791 (resolved February 22nd). But I guess that before MDL-64791 was fully integrated, MDL-64788 was raised and integrated (resolved February 15th), so the file is linked but doesn't exist.

      Maybe instead of recovering and fixing the old pendingcontactrequests.php, the link for 'xxx wants to be added as a contact' should be changed and pointed to same link as 'View full notification'.

      Thanks to Víctor Déniz Falcón for discovering this bug

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours, 5 minutes
                  5h 5m