Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65599

Invalid parameter value detected when dismissing the user competency summary modal

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.7
    • 3.7
    • Competencies
    • MOODLE_37_STABLE
    • MOODLE_37_STABLE
    • MDL-65599-master
    • Hide

      Setup

      1. Create a competency framework and add some competencies to the site. (Or import this competency framework: CCSS.Math-httpcorestandards.orgMath-20170106_0445-comma_separated.csv)
      2. Make sure there is a course with a teacher and student enrolled in it
      3. Log in as a teacher and select the course

      Test

      1. Go to the competencies page and add a competency to the course
      2. Go to competency breakdown report under course reports. (Course page -> Cog -> More... -> Reports -> Competency breakdown)
      3. Click a first time on "not rated" in Rating column then press the escape key to dismiss the modal
      4. Click a second time on "not rated" then press the escape key to dismiss the modal again
      5. Verify you do not see an exception modal about "Invalid parameter"
      Show
      Setup Create a competency framework and add some competencies to the site. (Or import this competency framework: CCSS.Math-httpcorestandards.orgMath-20170106_0445-comma_separated.csv ) Make sure there is a course with a teacher and student enrolled in it Log in as a teacher and select the course Test Go to the competencies page and add a competency to the course Go to competency breakdown report under course reports. (Course page -> Cog -> More... -> Reports -> Competency breakdown) Click a first time on "not rated" in Rating column then press the escape key to dismiss the modal Click a second time on "not rated" then press the escape key to dismiss the modal again Verify you do not see an exception modal about "Invalid parameter"

    Description

      As reported by jmeuriss in MDLQA-13390:

      getting an "invalid parameter exception" at step 6 of Test 2 when dismissing the modal showing the details of the competencies. The error doesn't occur when viewing dismissing the first modal window, but occurs with all the following ones. That is I view A2, dismiss the modal --> ok; I view B1 and dismiss the modal --> exception; I view B2 and dismiss the modal --> exception

      Could be reproduced on QA test site with the following steps.

      1. Log in as teacher and select a course
      2. Go to the competencies page and add a competency to the course
      3. Go to competency breakdown page 
      4. Click a first time on "not rated" in Rating column then dismiss the modal --> ok
      5. Click a second time on "not rated" then dismiss the modal --> exception thrown

      Invalid parameter value detected
      File: /lib/externallib.php
      Line: 349

      Stack trace:
      moduleid => Invalid parameter value detected (Invalid external api parameter: the value is "", the server was expecting "int" type): Invalid external api parameter: the value is "", the server was expecting "int" type
      Error code: invalidparameter

      • line 349 of /lib/externallib.php: invalid_parameter_exception thrown
      • line 223 of /lib/externallib.php: call to external_api::validate_parameters()
      • line 59 of /lib/ajax/service.php: call to external_api::call_external_function()

      Attachments

        Issue Links

          Activity

            People

              damyon Damyon Wiese
              tsala Helen Foster
              Simey Lameze Simey Lameze
              Jun Pataleta Jun Pataleta
              Janelle Barcega Janelle Barcega
              Jean-Philippe Gaudreau, Steve Massicotte, Serge Gauthier, Issam Taboubi, Jake Dallimore, Mathew May, Mihail Geshoski
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                20/May/19

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 18 minutes
                  2h 18m