-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.7
-
Fix Version/s: 3.7
-
Component/s: Competencies
-
Labels:
-
Testing Instructions:
Setup
- Create a competency framework and add some competencies to the site. (Or import this competency framework: CCSS.Math-httpcorestandards.orgMath-20170106_0445-comma_separated.csv
) - Make sure there is a course with a teacher and student enrolled in it
- Log in as a teacher and select the course
Test
- Go to the competencies page and add a competency to the course
- Go to competency breakdown report under course reports. (Course page -> Cog -> More... -> Reports -> Competency breakdown)
- Click a first time on "not rated" in Rating column then press the escape key to dismiss the modal
- Click a second time on "not rated" then press the escape key to dismiss the modal again
- Verify you do not see an exception modal about "Invalid parameter"
Setup Create a competency framework and add some competencies to the site. (Or import this competency framework: CCSS.Math-httpcorestandards.orgMath-20170106_0445-comma_separated.csv ) Make sure there is a course with a teacher and student enrolled in it Log in as a teacher and select the course Test Go to the competencies page and add a competency to the course Go to competency breakdown report under course reports. (Course page -> Cog -> More... -> Reports -> Competency breakdown) Click a first time on "not rated" in Rating column then press the escape key to dismiss the modal Click a second time on "not rated" then press the escape key to dismiss the modal again Verify you do not see an exception modal about "Invalid parameter" - Create a competency framework and add some competencies to the site. (Or import this competency framework: CCSS.Math-httpcorestandards.orgMath-20170106_0445-comma_separated.csv
-
Affected Branches:MOODLE_37_STABLE
-
Fixed Branches:MOODLE_37_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-65599-master -
Pull Master Diff URL:
As reported by Jean-Roch Meurisse in MDLQA-13390:
getting an "invalid parameter exception" at step 6 of Test 2 when dismissing the modal showing the details of the competencies. The error doesn't occur when viewing dismissing the first modal window, but occurs with all the following ones. That is I view A2, dismiss the modal --> ok; I view B1 and dismiss the modal --> exception; I view B2 and dismiss the modal --> exception
Could be reproduced on QA test site with the following steps.
- Log in as teacher and select a course
- Go to the competencies page and add a competency to the course
- Go to competency breakdown page
- Click a first time on "not rated" in Rating column then dismiss the modal --> ok
- Click a second time on "not rated" then dismiss the modal --> exception thrown
Invalid parameter value detected
File: /lib/externallib.php
Line: 349Stack trace:
moduleid => Invalid parameter value detected (Invalid external api parameter: the value is "", the server was expecting "int" type): Invalid external api parameter: the value is "", the server was expecting "int" type
Error code: invalidparameter
- line 349 of /lib/externallib.php: invalid_parameter_exception thrown
- line 223 of /lib/externallib.php: call to external_api::validate_parameters()
- line 59 of /lib/ajax/service.php: call to external_api::call_external_function()
- Discovered while testing
-
MDLQA-13390
CLONE - Competencies can be rated from a course and oblige to automatic rules
-
- Passed
-
