Details

    • Type: Sub-task
    • Status: Waiting for integration review
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.5.6, 3.6.4, 3.7
    • Fix Version/s: None
    • Component/s: Filepicker, JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      For all tests, open the browser dev tools to the "Network" tab.

      Problem D: Badges

      1. I am a teacher
      2. I am on a course page
      3. I click on "Badges"
      4. I click on "Add a new badge"
      5. I click on "Choose a file..."
        1. Confirm that there were no 404 errors shown in the Network tab

      Problem G: Folder

      1. I am a teacher
      2. I am on a course page
      3. I turn editing on
      4. I add a new folder setting only the name
      5. I view the new folder
      6. I click on "Edit"
      7. I click on the "Add..." icon in the file manager
        1. Confirm that there were no 404 errors shown in the Network tab

      Problem J: Backup

      1. I am a teacher
      2. I am on a course
      3. I open the settings menu
      4. I choose "Restore"
      5. I click on "Manage backup file"
      6. I click on the "Add..." icon in the file manager
        1. Confirm that there were no 404 errors shown in the Network tab

      Problem E: Lesson

      Note: There may be another way to reach this issue

      1. I am a teacher
      2. I am on a course with editing turned on
      3. I create a new lesson
      4. I click on "Import questions"
      5. I click the "Import" button without entering a file
      6. I click on the "Choose a file..." button
        1. Confirm that there were no 404 errors shown in the Network tab
      Show
      For all tests, open the browser dev tools to the "Network" tab. Problem D: Badges I am a teacher I am on a course page I click on "Badges" I click on "Add a new badge" I click on "Choose a file..." Confirm that there were no 404 errors shown in the Network tab Problem G: Folder I am a teacher I am on a course page I turn editing on I add a new folder setting only the name I view the new folder I click on "Edit" I click on the "Add..." icon in the file manager Confirm that there were no 404 errors shown in the Network tab Problem J: Backup I am a teacher I am on a course I open the settings menu I choose "Restore" I click on "Manage backup file" I click on the "Add..." icon in the file manager Confirm that there were no 404 errors shown in the Network tab Problem E: Lesson Note: There may be another way to reach this issue I am a teacher I am on a course with editing turned on I create a new lesson I click on "Import questions" I click the "Import" button without entering a file I click on the "Choose a file..." button Confirm that there were no 404 errors shown in the Network tab
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull 3.6 Branch:
    • Pull 3.7 Branch:
    • Pull Master Branch:
      MDL-65604-master

      Description

      Intro

      A number of the missing params come from the following scenario:

      1. I am on a page which has a file manager
      2. There are no query params in the current URL because the current page was reached via a POST
      3. I open the file manager

      The act of opening the file manager causes the current page to be fetched for some reason. I haven't worked out why yet - the code is difficult to follow and the inspector claims that it has come from setting the innerHTML of some part of the file manager, however I'm unable to work out which one as none of them contain the offending URLs.

      Replication instructions:

      Problem D: Badges

      1. I am a teacher
      2. I am on a course page
      3. I click on "Badges"
      4. I click on "Add a new badge"
      5. I click on "Choose a file..."

      Problem G: Folder

      1. I am a teacher
      2. I am on a course page
      3. I turn editing on
      4. I add a new folder setting only the name
      5. I view the new folder
      6. I click on "Edit"
      7. I click on the "Add..." icon in the file manager

      Problem J: Backup

      1. I am a teacher
      2. I am on a course
      3. I open the settings menu
      4. I choose "Restore"
      5. I click on "Manage backup file"
      6. I click on the "Add..." icon in the file manager

      Problem E: Lesson

      Note: There may be another way to reach this issue

      1. I am a teacher
      2. I am on a course with editing turned on
      3. I create a new lesson
      4. I click on "Import questions"
      5. I click the "Import" button without entering a file
      6. I click on the "Choose a file..." button
        Note: I haven't worked out how to reproduce this issue on the editpage.php URL

        Attachments

          Activity

            People

            • Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Mihail Geshoski
              Participants:
              Component watchers:
              Adrian Greeve, Mihail Geshoski, Peter Dias, Jake Dallimore, Jun Pataleta, Ryan Wyllie
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 20 minutes
                1h 20m