Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65607

New global functions without prefix

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.7
    • Fix Version/s: 3.7
    • Component/s: Forum
    • Labels:
    • Testing Instructions:
      Hide
      1. In mod/forum/lib.php make sure the following old functions do not exist anymore and have been renamed
        Old function name New function name
        get_discussions mod_forum_get_discussion_summaries
        get_count_all_discussions mod_forum_count_all_discussions
        get_groups_from_groupid  mod_forum_get_groups_from_groupid
      2. Make sure the new function names have been updated in all the places where these functions are being used.
      Show
      In mod/forum/lib.php make sure the following old functions do not exist anymore and have been renamed Old function name New function name get_discussions mod_forum_get_discussion_summaries get_count_all_discussions mod_forum_count_all_discussions get_groups_from_groupid  mod_forum_get_groups_from_groupid Make sure the new function names have been updated in all the places where these functions are being used.
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      MDL-65607-master
    • Pull Master Diff URL:

      Description

      mod/forum/lib.php now contains the following new, global functions:

      1. get_discussions
      2. get_count_all_discussions
      3. get_groups_from_groupid

      These must be prefixed with forum_ or mod_forum_ if they have to remain in the global function at all, but I don't know why they are global functions at all anyway.

        Attachments

          Activity

            People

            Assignee:
            Geshoski Mihail Geshoski
            Reporter:
            dobedobedoh Andrew Lyons
            Peer reviewer:
            Simey Lameze Simey Lameze
            Integrator:
            Jun Pataleta Jun Pataleta
            Tester:
            CiBoT CiBoT
            Participants:
            Component watchers:
            Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              20/May/19

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 21 minutes
                2h 21m