[MDL-65607] New global functions without prefix - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Blocker
Resolution: Fixed
Affects Version/s: 3.7
Fix Version/s: 3.7
Component/s: Forum
Labels:
- ci
- triaged

Testing Instructions:

Hide

In mod/forum/lib.php make sure the following old functions do not exist anymore and have been renamed

Old function name	New function name
get_discussions	mod_forum_get_discussion_summaries
get_count_all_discussions	mod_forum_count_all_discussions
get_groups_from_groupid	mod_forum_get_groups_from_groupid

Make sure the new function names have been updated in all the places where these functions are being used.

Show

In mod/forum/lib.php make sure the following old functions do not exist anymore and have been renamed Old function name New function name get_discussions mod_forum_get_discussion_summaries get_count_all_discussions mod_forum_count_all_discussions get_groups_from_groupid mod_forum_get_groups_from_groupid Make sure the new function names have been updated in all the places where these functions are being used.

Affected Branches:
MOODLE_37_STABLE
Fixed Branches:
MOODLE_37_STABLE
Epic Link:
Forum facelift
Pull from Repository:
git://github.com/mihailges/moodle.git
Pull Master Branch:
~~MDL-65607~~-master
Pull Master Diff URL:
https://github.com/mihailges/moodle/compare/b742fe1403...MDL-65607-master

Description

mod/forum/lib.php now contains the following new, global functions:

get_discussions
get_count_all_discussions
get_groups_from_groupid

These must be prefixed with forum_ or mod_forum_ if they have to remain in the global function at all, but I don't know why they are global functions at all anyway.

Attachments

Activity

People

Assignee:: Mihail Geshoski

Reporter:: Andrew Nicols

Peer reviewer:: Simey Lameze

Integrator:: Jun Pataleta

Tester:: CiBoT

Participants:: Andrew Nicols, CiBoT, Eloy Lafuente (stronk7), Jun Pataleta, Mihail Geshoski, Simey Lameze

Component watchers:: Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 15/May/19 11:44 AM

Updated:: 16/May/19 5:45 PM

Resolved:: 16/May/19 5:45 PM

Fix Release Date:: 20/May/19

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

2h 21m