Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65610

Undefined index warning editing LTI preconfigured tool

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Setup

      1. Make sure your site is available on a publicly accessible url (ngrok is fine)

      Test

      1. Login as admin
      2. Go to "Site administration -> Plugins -> External tool -> Manage tools"
      3. Add an external tool with the url "https://lti.tools/test/tp.php"
      4. Register and activate the tool
      5. Edit the tool settings and save the form
      6. Verify you don't see the "Undefined index warning".
      Show
      Setup Make sure your site is available on a publicly accessible url (ngrok is fine) Test Login as admin Go to "Site administration -> Plugins -> External tool -> Manage tools" Add an external tool with the url "https://lti.tools/test/tp.php" Register and activate the tool Edit the tool settings and save the form Verify you don't see the "Undefined index warning".
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-65610-master
    • Pull Master Diff URL:

      Description

      An LTI preconfigured tool that is for LTI2 does not have a field containing the 'lti_ltiversion'.

      When editing a tool that was created as LTI2 tool this generates a warning:

      Notice: Undefined index: lti_ltiversion in /home/damyon/moodles/integration_master/moodle/mod/lti/edit_form.php on line 355

        Attachments

          Issue Links

          blocks

          Functional Test - A test of a single Moodle feature MDLQA-13403 CLONE - LTI tools can be added to LTI manage tools page

          • Minor - Minor loss of function where workaround is possible
          • Passed
          is a regression caused by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-65536 LTI 1.3 post-landing issues

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

            Activity

              People

              Assignee:
              damyon Damyon Wiese
              Reporter:
              damyon Damyon Wiese
              Peer reviewer:
              Jake Dallimore
              Integrator:
              Jun Pataleta
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                20/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 28 minutes
                  1h 28m