Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65619

Default notification preferences are unset by default for Permitted/Locked/Disallowed

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.7
    • Fix Version/s: 3.7
    • Component/s: Messages
    • Testing Instructions:
      Hide
      1. As admin go to Site administration -> Messaging -> Notification settings
      2. If Email is not Enable, enable it and Save Changes.
      3. If Email is Enable, checked (or change) some of Default notification preferences for Email column are Permitted, some are Locked and some Disallowed.
        1. Set 'Assignment notifications' to Permitted.
        2. Set 'Asynchronous backup/restore notifications' to Permitted.
        3. Set 'Warning when your quiz attempt becomes overdue' to Disallowed.
        4. Set 'Available update notifications' to Locked.
      4. Save Changes.
      5. Unchecked Email Notification plugins checkbox to disable it and Save changes.
      6. EXPECTED RESULT: Check that Email column is not displayed in Default notification preferences.
      7. Now, enable Email Notification plugin in Site administration -> Messaging -> Notification settings and Save changes.
      8. EXPECTED RESULT: Check that the email column is displayed in Default notification preferences.
      9. EXPECTED RESULT: Check that:
        1. 'Assignment notifications' is set to Permitted.
        2. Set 'Asynchronous backup/restore notifications' is set to Permitted.
        3. 'Warning when your quiz attempt becomes overdue' is set to Disallowed.
        4. 'Available update notifications' is set to Locked.
      Show
      As admin go to Site administration -> Messaging -> Notification settings If Email is not Enable, enable it and Save Changes. If Email is Enable, checked (or change) some of Default notification preferences for Email column are Permitted, some are Locked and some Disallowed. Set 'Assignment notifications' to Permitted. Set 'Asynchronous backup/restore notifications' to Permitted. Set 'Warning when your quiz attempt becomes overdue' to Disallowed. Set 'Available update notifications' to Locked. Save Changes. Unchecked Email Notification plugins checkbox to disable it and Save changes. EXPECTED RESULT: Check that Email column is not displayed in Default notification preferences. Now, enable Email Notification plugin  in Site administration -> Messaging -> Notification settings and Save changes. EXPECTED RESULT:  Check that the email column is displayed in Default notification preferences. EXPECTED RESULT:  Check that: 'Assignment notifications' is set to Permitted. Set 'Asynchronous backup/restore notifications' is set to Permitted. 'Warning when your quiz attempt becomes overdue' is set to Disallowed. 'Available update notifications' is set to Locked.
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-65619-master

      Description

      After changes made in MDL-64495 adding a new Notification settings page, both Notification plugins' settings and Default notification preferences are altogether. As discussed in MDL-64495, when admin enables a new notification provider, no default notification preferences column appears. But when they click on Save changes, all preferences for all providers are saved, even the preferences don't exist in the page. 

      This behavior doesn't respect default values for user preferences and unsets all default preferences. 

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  20/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 35 minutes
                  3h 35m