[MDL-65620] Default notification preferences are unset by default - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.6, 3.7, 3.8
Fix Version/s: 3.7.4, 3.8.1
Component/s: Messages
Labels:

Affected Branches:
MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
Fixed Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE
Pull from Repository:
git://github.com/aanabit/moodle.git
Pull Master Branch:
~~MDL-65620~~-master
Pull Master Diff URL:
https://github.com/aanabit/moodle/compare/MDL-65620-master~3...MDL-65620-master
Testing Instructions:
Hide

As admin go to Site administration -> Messaging -> Notification settings

If Email is not Enable, enable it and Save Changes.

If Email is Enable, checked (or change) some of Default notification preferences for Email column are Permitted, and some Online and Offline checkboxes in Email column are checked. For example, let's say Email for 'Assignment notifications' is Permitted, Online is checked and Offline is not checked. And Save changes if you have changed some of the values.

Unchecked Email Notification plugins checkbox to disable it and Save changes.

Check Email column is not in Default notification preferences.

Enable Email Notification plugin and Save changes.

Check same setting values from step 3. are kept.
Show
As admin go to Site administration -> Messaging -> Notification settings If Email is not Enable, enable it and Save Changes. If Email is Enable, checked (or change) some of Default notification preferences for Email column are Permitted, and some Online and Offline checkboxes in Email column are checked. For example, let's say Email for 'Assignment notifications' is Permitted, Online is checked and Offline is not checked. And Save changes if you have changed some of the values. Unchecked Email Notification plugins checkbox to disable it and Save changes. Check Email column is not in Default notification preferences. Enable Email Notification plugin and Save changes. Check same setting values from step 3. are kept.

Story Points:
3
Sprint:
Moppies Moodle 3.8 Sprint 1, Moppies Moodle 3.8 Sprint 2, Moppies Moodle 3.8 Sprint 3, Moppies Moodle 3.8 Sprint 4, Moppies Moodle 3.8 Sprint 5, Moppies Moodle 3.8 Sprint 6, Moppies Kanban

Description

Only Permitted/Locked/Disallowed values are kept when admins disabled a notification provider.

All default values should be kept when a provider is disabled to recover them in case the provider is enabled again.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

screenshot-1.png
78 kB
05/Dec/19 9:49 AM

Issue Links

caused a regression

MDL-68339 Invalid array operations on objects recently introduced

Closed

Discovered while testing

MDL-65619 Default notification preferences are unset by default for Permitted/Locked/Disallowed

Closed

has to be done before

MDL-66883 Use Bootstrap switch element instead of 'switch' class

Closed

is blocked by

MDL-66396 Checkbox disappears for disabled messaging notification settings (regression)

Closed

Testing discovered

MDL-66396 Checkbox disappears for disabled messaging notification settings (regression)

Closed

will help resolve

MDL-65221 Add behat test for new UI to manage messaging notification preferences

Closed

(1 will help resolve)

Activity

People

Assignee:: Amaia Anabitarte

Reporter:: Amaia Anabitarte

Integrator:: Adrian Greeve

Tester:: Janelle Barcega

Participants:: Adrian Greeve, Amaia Anabitarte, CiBoT, Eloy Lafuente (stronk7), Jake Dallimore, Janelle Barcega

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 1 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 16/May/19 12:44 AM

Updated:: 06/Apr/20 1:30 AM

Resolved:: 05/Dec/19 8:45 PM

Fix Release Date:: 13/Jan/20

Time Tracking

Estimated:

Remaining:

Logged:

3d 4h 54m