Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65635

Inline replies carriage returns are lost (an interim and imperfect solution)

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Prerequisites

      1. To be able to verify other formats different from MOODLE and HTML, install the Marklar editor (https://moodle.org/plugins/editor_marklar), that will allow us to verify that things are ok for people using the MARKDOWN format (via preferred editor) too.

      Setup

      1. Login as admin.
      2. Create a course.
      3. Create a "Standard forum for general use".
      4. Post a message in the forum.

      Testing scenario 1.1: submit inline-reply with Atto as default editor

      1. Access to the User profile.
      2. Click the cog and go to the "Editor preferences".
      3. Change the "Text editor" to "Atto HTML editor".
      4. Open the forum discussion created during the setup.
      5. Click the "Reply" button.
      6. CHECK the inline textarea is opened with the text "Write your reply..."
      7. Compose a text with, at least, 2 lines and 1 carriage return.
      8. Submit the message.
      9. CHECK the break-lines added are respected and the text is displayed as expected.
      10. Edit the just created post
      11. CHECK the Atto editor is opened, containing the text written in the inline-reply. With the break lines.

      Testing scenario 1.2: submit inline-reply with Plain text as default editor

      1. Access to the User profile.
      2. Click the cog and go to the "Editor preferences".
      3. Change the "Text editor" to "Plain text".
      4. Open the forum discussion created during the setup.
      5. Click the "Reply" button.
      6. CHECK the inline textarea is opened with the text "Write your reply..."
      7. Compose a text with, at least, 2 lines and 1 carriage return.
      8. Submit the message.
      9. CHECK the break-lines added are respected and the text is displayed as expected.
      10. Edit the just created post
      11. CHECK the Plain text box is opened, containing the text written in the inline-reply. With the break lines.

      Testing scenario 1.3: submit inline-reply with Marklar as default editor

      1. Access to the User profile.
      2. Click the cog and go to the "Editor preferences".
      3. Change the "Text editor" to "Marklar".
      4. Open the forum discussion created during the setup.
      5. Click the "Reply" button.
      6. CHECK the inline textarea is opened with the text "Write your reply..."
      7. Compose a text with, at least, 2 lines and 1 carriage return.
      8. Submit the message.
      9. CHECK the break-lines added are respected and the text is displayed as expected.
      10. Edit the just created post
      11. CHECK the Marklar editor is opened, containing the text written in the inline-reply. With the break lines.

      Testing scenario 2.1: inline-reply to advanced with Atto as default editor

      1. Access to the User profile.
      2. Click the cog and go to the "Editor preferences".
      3. Change the "Text editor" to "Atto HTML editor".
      4. Open the forum discussion created during the setup.
      5. Click the "Reply" button.
      6. CHECK the inline textarea is opened with the text "Write your reply..."
      7. Compose a text with, at least, 2 lines and 1 carriage return.
      8. Click the "Advanced" button.
      9. CHECK the Atto editor is opened, with the text written in the inline-reply.
      10. CHECK the break-lines are respected and the text is displayed inside the editor as expected.

      Testing scenario 2.2: inline-reply to advanced with Plain text area as default editor

      1. Access to the User profile.
      2. Click the cog and go to the "Editor preferences".
      3. Change the "Text editor" to "Plain text area".
      4. Open the forum discussion created during the setup.
      5. Click the "Reply" button.
      6. CHECK the inline textarea is opened with the text "Write your reply..."
      7. Compose a text with, at least, 2 lines and 1 carriage return.
      8. Click the "Advanced" button.
      9. CHECK the plain text editor is opened, containing the text written in the inline-reply.
      10. CHECK the break-lines are respected and the text is displayed inside the editor as expected.

      Testing scenario 2.3: inline-reply to advanced with Marklar as default editor

      1. Access to the User profile.
      2. Click the cog and go to the "Editor preferences".
      3. Change the "Text editor" to "Marklar".
      4. Open the forum discussion created during the setup.
      5. Click the "Reply" button.
      6. CHECK the inline textarea is opened with the text "Write your reply..."
      7. Compose a text with, at least, 2 lines and 1 carriage return.
      8. Click the "Advanced" button.
      9. CHECK the Marklar editor is opened, containing the text written in the inline-reply.
      10. CHECK the break-lines are respected and the text is displayed inside the editor as expected.
      Show
      Prerequisites To be able to verify other formats different from MOODLE and HTML, install the Marklar editor ( https://moodle.org/plugins/editor_marklar ), that will allow us to verify that things are ok for people using the MARKDOWN format (via preferred editor) too. Setup Login as admin. Create a course. Create a "Standard forum for general use". Post a message in the forum. Testing scenario 1.1: submit inline-reply with Atto as default editor Access to the User profile. Click the cog and go to the "Editor preferences". Change the "Text editor" to "Atto HTML editor". Open the forum discussion created during the setup. Click the "Reply" button. CHECK the inline textarea is opened with the text "Write your reply..." Compose a text with, at least, 2 lines and 1 carriage return. Submit the message. CHECK the break-lines added are respected and the text is displayed as expected. Edit the just created post CHECK the Atto editor is opened, containing the text written in the inline-reply. With the break lines. Testing scenario 1.2: submit inline-reply with Plain text as default editor Access to the User profile. Click the cog and go to the "Editor preferences". Change the "Text editor" to "Plain text". Open the forum discussion created during the setup. Click the "Reply" button. CHECK the inline textarea is opened with the text "Write your reply..." Compose a text with, at least, 2 lines and 1 carriage return. Submit the message. CHECK the break-lines added are respected and the text is displayed as expected. Edit the just created post CHECK the Plain text box is opened, containing the text written in the inline-reply. With the break lines. Testing scenario 1.3: submit inline-reply with Marklar as default editor Access to the User profile. Click the cog and go to the "Editor preferences". Change the "Text editor" to "Marklar". Open the forum discussion created during the setup. Click the "Reply" button. CHECK the inline textarea is opened with the text "Write your reply..." Compose a text with, at least, 2 lines and 1 carriage return. Submit the message. CHECK the break-lines added are respected and the text is displayed as expected. Edit the just created post CHECK the Marklar editor is opened, containing the text written in the inline-reply. With the break lines. Testing scenario 2.1: inline-reply to advanced with Atto as default editor Access to the User profile. Click the cog and go to the "Editor preferences". Change the "Text editor" to "Atto HTML editor". Open the forum discussion created during the setup. Click the "Reply" button. CHECK the inline textarea is opened with the text "Write your reply..." Compose a text with, at least, 2 lines and 1 carriage return. Click the "Advanced" button. CHECK the Atto editor is opened, with the text written in the inline-reply. CHECK the break-lines are respected and the text is displayed inside the editor as expected. Testing scenario 2.2: inline-reply to advanced with Plain text area as default editor Access to the User profile. Click the cog and go to the "Editor preferences". Change the "Text editor" to "Plain text area". Open the forum discussion created during the setup. Click the "Reply" button. CHECK the inline textarea is opened with the text "Write your reply..." Compose a text with, at least, 2 lines and 1 carriage return. Click the "Advanced" button. CHECK the plain text editor is opened, containing the text written in the inline-reply. CHECK the break-lines are respected and the text is displayed inside the editor as expected. Testing scenario 2.3: inline-reply to advanced with Marklar as default editor Access to the User profile. Click the cog and go to the "Editor preferences". Change the "Text editor" to "Marklar". Open the forum discussion created during the setup. Click the "Reply" button. CHECK the inline textarea is opened with the text "Write your reply..." Compose a text with, at least, 2 lines and 1 carriage return. Click the "Advanced" button. CHECK the Marklar editor is opened, containing the text written in the inline-reply. CHECK the break-lines are respected and the text is displayed inside the editor as expected.
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Sam Marshall has noticed that the new inline replies lost all the carriage returns, so there are no paragraph breaks in the post and it's needed to edit it to put them back in.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  20/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 6 hours, 45 minutes
                  1d 6h 45m