Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65677

Links to grader page doesn't work properly if filter enabled

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Not a bug
    • Affects Version/s: 3.7
    • Fix Version/s: None
    • Component/s: Assignment
    • Labels:
      None
    • Workaround:
      Hide

      Can be fixed (not in the best way) by editing function "list_participants" in "mod/assign/externallib.php".

      Instead of line:

      $participants = $assign->list_participants_with_filter_status_and_group($params['groupid'], $params['tablesort']);

      Enter:

      //Core Fix Start
      $prefs = json_decode(get_user_preferences('flextable_mod_assign_grading'), true);
      $temp_prefs = $prefs;
      $temp_prefs['i_first'] = '';
      $temp_prefs['i_last'] = '';
      set_user_preference('flextable_mod_assign_grading', json_encode($temp_prefs));
      //Core Fix Finish
      $participants = $assign->list_participants_with_filter_status_and_group($params['groupid'], $params['tablesort']);
      //Core Fix Start
      set_user_preference('flextable_mod_assign_grading', json_encode($prefs));
      //Core Fix Finish

      Show
      Can be fixed (not in the best way) by editing function "list_participants" in "mod/assign/externallib.php". Instead of line: $participants = $assign->list_participants_with_filter_status_and_group($params ['groupid'] , $params ['tablesort'] ); Enter: //Core Fix Start $prefs = json_decode(get_user_preferences('flextable_mod_assign_grading'), true); $temp_prefs = $prefs; $temp_prefs ['i_first'] = ''; $temp_prefs ['i_last'] = ''; set_user_preference('flextable_mod_assign_grading', json_encode($temp_prefs)); //Core Fix Finish $participants = $assign->list_participants_with_filter_status_and_group($params ['groupid'] , $params ['tablesort'] ); //Core Fix Start set_user_preference('flextable_mod_assign_grading', json_encode($prefs)); //Core Fix Finish
    • Affected Branches:
      MOODLE_37_STABLE

      Description

      Those kind of links are leading to grading pages in assignments:

      /mod/assign/view.php?id=23&userid=1032&rownum=0&action=grader

      I use them in grading plugin and generate them myself. After upgrading to Moodle 3.7 grading page starts to apply silently filter (lastname and firstname) from "view all answers" page (/mod/assign/view.php?id=23&action=grading).

      For example, if you have on a "view all answers" page filter enabled by lastname (tilast=A), you are not able to navigate to any user grading page, whos lastname is now starting form "A". You just get redirected to any user, who fits the filter.

      Probably, it is js redirections. Trying to find it, but whiout luck yet.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              evsoldatkin Evgeny Soldatkin
              Participants:
              Component watchers:
              Damyon Wiese, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: