Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65679

Expanding/collapsing PDF comments causes other annotations to change position

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Note: Test in all browsers

      Setup:

      Test

      1. Login as a teacher to the new course
      2. Create an assignment that allows "online text" submissions and has "Annotate PDF" enabled for feedback
      3. Edit the submission for the first student (any text will do)
      4. Grade this student and add some comments with a lot of text and at least one of every other type of drawing close to the comment. (Stamp, Squiggle, Line, Square, Circle, Highlight)
      5. Choose the "Pointer" tool and hover over the comment
      6. Verify the comment expands and show over the top of the other drawings
        1. Verify the other drawings don't move.
        2. Verify that the comment is visible over the other elements
      7. Go to the "View all submissions" page
        1. Verify the read only "View annotated PDF..." modal window acts the same way when the comments are hovered over with the mouse.
      Show
      Note: Test in all browsers Setup: Login as admin Setup and enable the Unoconv document converter:  https://docs.moodle.org/37/en/Universal_Office_Converter_(unoconv) Create a course with some editing teachers and students enrolled Test Login as a teacher to the new course Create an assignment that allows "online text" submissions and has "Annotate PDF" enabled for feedback Edit the submission for the first student (any text will do) Grade this student and add some comments with a lot of text and at least one of every other type of drawing close to the comment. (Stamp, Squiggle, Line, Square, Circle, Highlight) Choose the "Pointer" tool and hover over the comment Verify the comment expands and show over the top of the other drawings Verify the other drawings don't move. Verify that the comment is visible over the other elements Go to the "View all submissions" page Verify the read only "View annotated PDF..." modal window acts the same way when the comments are hovered over with the mouse.
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull 3.6 Branch:
    • Pull 3.7 Branch:
    • Pull Master Branch:
      MDL-65679-master

      Description

      This is a regression in assignfeedback_editpdf introduced by MDL-65484.

      Because annotations and comments are now relatively positioned, expanding and collapsing comments pushes subsequent annotations/comments up and down the page.

        Attachments

        1. collapsed.png
          collapsed.png
          42 kB
        2. expanded.png
          expanded.png
          49 kB
        3. MDL-65679_Step6.jpg
          MDL-65679_Step6.jpg
          68 kB
        4. step6.mp4
          1.97 MB

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Sep/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 6 hours, 11 minutes
                  6h 11m