Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65686

Bad call to send_file_not_found in lib/filelib.php

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.6.5, 3.7.1
    • 3.6, 3.7, 3.8
    • Files API

      There's an instance of send_file_not_found without its () after it - as I write, this is line 4240 in master. (Line 4221 in 36_STABLE)

      I haven't seen the code get to it - but if it did, it would throw a warning (constant not defined, in some future version this will be an Error) and then promptly do nothing as it'll evaluate to an expression that will do nothing, and pass through to the next thing which is probably not desirable.

      Easy fix, just needs to be changed from send_file_not_found to send_file_not_found().

      If I get time I'll throw a patch together.

            matteo Matteo Scaramuccia
            peter.spicer Peter Spicer
            Damyon Wiese Damyon Wiese
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            CiBoT CiBoT
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 10 minutes
                10m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.