Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65692

Asynchronous course backup/restore email message settings are empty by default

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Fresh install

      1. Install a new site.
      2. Log in as the admin.
      3. Go to 'Site administration > Courses > Backups > Asynchronous backup/restore'
      4. Check that there is only one setting showing - Enable asynchronous backups and that it is disabled.
      5. Enable the setting, a new setting should appear (Enable message notifications). Enable that as well.
      6. Subject and message should now be displayed. Check that the default values are in the text box and text area.

      Upgrade no alteration

      1. Install a new site, but checkout the commit before this change. git checkout 07839e6af3c981da388ddf0a4776b06a0eb2ff54 – master and git checkout 7a2beab44e932f7b9cf5f8df944fb799a93624f9 – 3.7
      2. Log in as the admin.
      3. Go to 'Site administration > Advanced features' and just check that Enable asynchronous backups is not enabled.
      4. Check out the most recent branch git reset --hard origin/master switch master for MOODLE_37_STABLE for 3.7.
      5. Run through the upgrade.
      6. During the upgrade you should be met with a page with asynchronous backup/restore settings.
      7. Check that subject and message are filled with the default values.
      8. Click save changes and continue with the upgrade.
      9. Go to 'Site administration > Courses > Backups > Asynchronous backup/restore'
      10. Check that there is only one setting showing - Enable asynchronous backups and that it is disabled.
      11. Enable the setting, a new setting should appear (Enable message notifications). Enable that as well.
      12. Subject and message should now be displayed. Check that the default values are in the text box and text area.

      Upgrade with alteration to settings

      1. Install a new site, but checkout the commit before this change. git checkout 07839e6af3c981da388ddf0a4776b06a0eb2ff54 – master and git checkout 7a2beab44e932f7b9cf5f8df944fb799a93624f9 – 3.7
      2. Log in as the admin.
      3. Go to 'Site administration > Advanced features' and enable Enable asynchronous backups.
      4. Go to 'Site administration > Courses > Backups > Asynchronous backup/restore'
      5. Enable 'Enable message notifications'
      6. Enter in some text in both 'Subject' and 'Message'.
      7. Check out the most recent branch git reset --hard origin/master switch master for MOODLE_37_STABLE for 3.7.
      8. Run through the upgrade.
      9. Go to 'Site administration > Courses > Backups > Asynchronous backup/restore'
      10. Check that both 'Enable asynchronous backups' and 'Enable message notifications' are enabled.
      11. Check that the subject and message are still the same as what was entered in step 6.
      Show
      Fresh install Install a new site. Log in as the admin. Go to 'Site administration > Courses > Backups > Asynchronous backup/restore' Check that there is only one setting showing - Enable asynchronous backups and that it is disabled. Enable the setting, a new setting should appear (Enable message notifications). Enable that as well. Subject and message should now be displayed. Check that the default values are in the text box and text area. Upgrade no alteration Install a new site, but checkout the commit before this change. git checkout 07839e6af3c981da388ddf0a4776b06a0eb2ff54 – master and git checkout 7a2beab44e932f7b9cf5f8df944fb799a93624f9 – 3.7 Log in as the admin. Go to 'Site administration > Advanced features' and just check that Enable asynchronous backups is not enabled. Check out the most recent branch git reset --hard origin/master switch master for MOODLE_37_STABLE for 3.7. Run through the upgrade. During the upgrade you should be met with a page with asynchronous backup/restore settings. Check that subject and message are filled with the default values. Click save changes and continue with the upgrade. Go to 'Site administration > Courses > Backups > Asynchronous backup/restore' Check that there is only one setting showing - Enable asynchronous backups and that it is disabled. Enable the setting, a new setting should appear (Enable message notifications). Enable that as well. Subject and message should now be displayed. Check that the default values are in the text box and text area. Upgrade with alteration to settings Install a new site, but checkout the commit before this change. git checkout 07839e6af3c981da388ddf0a4776b06a0eb2ff54 – master and git checkout 7a2beab44e932f7b9cf5f8df944fb799a93624f9 – 3.7 Log in as the admin. Go to 'Site administration > Advanced features' and enable Enable asynchronous backups. Go to 'Site administration > Courses > Backups > Asynchronous backup/restore' Enable 'Enable message notifications' Enter in some text in both 'Subject' and 'Message'. Check out the most recent branch git reset --hard origin/master switch master for MOODLE_37_STABLE for 3.7. Run through the upgrade. Go to 'Site administration > Courses > Backups > Asynchronous backup/restore' Check that both 'Enable asynchronous backups' and 'Enable message notifications' are enabled. Check that the subject and message are still the same as what was entered in step 6.
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull from Repository:
    • Pull 3.7 Branch:
    • Pull Master Branch:
      MDL-65692-master

      Description

      To reproduce:

      1. Create a 3.6 site, then upgrade it to 3.7
      2. Enable async backup and restore ("Administration" > "Advanced features")
      3. Enable email notifications for async backup/restore ("Administration" > "Courses" > "Backups" > "Asynchronous backup/restore") - do not enter anything in the subject and message fields, then save the form
      4. Check the config_plugins table, you'll see empty values for things like backup_async_message (instead of the defaults that are specified on the email notifications form)

      When a user enables the email messages as per the testing instructions on MDL-28505, they will see an empty subject and body.

      I'm not sure if this is a bug with moodle core itself, or just the async backup settings page

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  8/Jul/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 1 hour, 10 minutes
                  1d 1h 10m