[MDL-65708] Child themes no longer have base layouts loaded - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.7, 3.7 regressions
Fix Version/s: 3.7.1
Component/s: Themes
Labels:

Testing Instructions:

Hide

Note: the fix has been successfully tested on learn.moodle.net during the peer-review

To test this, you need a custom theme that uses the Boost as the parent theme. Your theme should not define its layouts (or not all of them at least). Instead, it should simply rely on the parent to provide their full list. https://moodle.org/plugins/theme_photo is an example of such a theme.

Without this fix, such a theme will not simply work and will display the reported errors.

With the fix, the theme should work again.

Show
Note: the fix has been successfully tested on learn.moodle.net during the peer-review To test this, you need a custom theme that uses the Boost as the parent theme. Your theme should not define its layouts (or not all of them at least). Instead, it should simply rely on the parent to provide their full list. https://moodle.org/plugins/theme_photo is an example of such a theme. Without this fix, such a theme will not simply work and will display the reported errors. With the fix, the theme should work again.
Affected Branches:
MOODLE_37_STABLE
Fixed Branches:
MOODLE_37_STABLE
Pull from Repository:
git://github.com/Chocolate-lightning/moodle.git
Pull 3.7 Branch:
~~MDL-65708~~-37
Pull 3.7 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_37_STABLE...Chocolate-lightning:MDL-65708-37
Pull Master Branch:
~~MDL-65708~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...Chocolate-lightning:MDL-65708-master

Description

The site learn.moodle.net uses a custom theme which is a child theme of the Boost. After upgrading the site to 3.7, it stopped working with error messages like

Invalid page layout specified: login

Undefined index: standard in lib/outputlib.php on line 2464

These are layouts provided by the boost's config file. Our custom theme only defines its own frontpage layout. All others are supposed to be inherited.

It turned out to be a regression of ~~MDL-64506~~ - the commit e00f1c663c1 changed the way how theme_config::__construct() sets the $baseconfig - before, it was always the bootstrapbase - so it loaded all its layouts etc. But now, we do not use it.

Attachments

Issue Links

blocks

MDLSITE-5731 Upgrade learn.moodle.net to 3.7

Closed

is a regression caused by

MDL-64506 Remove clean theme

Closed

is duplicated by

MDL-65645 Theme layouts do not inherit from parent theme

Closed

Activity

People

Assignee:: Mathew May

Reporter:: David Mudrák (@mudrd8mz)

Peer reviewer:: David Mudrák (@mudrd8mz)

Integrator:: Andrew Nicols

Tester:: Peter Dias

Participants:: Andrew Nicols, CiBoT, David Mudrák (@mudrd8mz), Eloy Lafuente (stronk7), Mathew May, Peter Dias

Component watchers:: Bas Brands

Votes:: 0 Vote for this issue

Watchers:: 11 Start watching this issue

Dates

Created:: 24/May/19 4:39 PM

Updated:: 02/Jul/19 4:52 PM

Resolved:: 30/May/19 7:35 PM

Fix Release Date:: 8/Jul/19

Time Tracking

Estimated:

Remaining:

Logged:

2h 17m