XML

Word

Printable

Details

Type: Task
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.8
Fix Version/s: 3.10
Component/s: Libraries
Labels:

Affected Branches:
MOODLE_38_STABLE
Fixed Branches:
MOODLE_310_STABLE
Epic Link:
Libraries 3.10
Pull from Repository:
git://github.com/lameze/moodle.git
Pull Master Branch:
~~MDL-65743~~-master
Pull Master Diff URL:
https://github.com/lameze/moodle/compare/87afa4d759...MDL-65743-master

Testing Instructions:

Hide

Regression test

We need to make sure XMPPHP still works as expected after the upgrade.

As the admin user, run the local jabber server (https://hub.docker.com/r/rroemhild/ejabberd) configured with 2 users, and no TLS.

docker run  --name "ejabberd" \

-p 5222:5222   \

-p 5269:5269   \

-p 5280:5280   \

-h 'xmpp.localhost'   \

-e "XMPP_DOMAIN=localhost"  \

-e "EJABBERD_ADMINS=admin@localhost admin2@localhost"   \

-e "EJABBERD_USERS=admin@localhost:password1234 admin2@localhost:password4321"  \

-e "TZ=Europe/Berlin"   \

-e "EJABBERD_STARTTLS=false"  rroemhild/ejabberd

In Moodle, enable Jabber and configure the server details. Set:
- host: 'localhost'
- Jabber server: NOT SET
- Username: admin
- Password: password1234.
Via 'Default notification preferences' (Site administration > Messaging > Notification settings) enable Jabber for offline AND online use for the 'Personal messages between users' row. Make sure the select is set to 'Permitted'.
Create a course and enrol 2 students, student 1 and student 2.
Log out.
Log in as student 1.
Click the notifications bell, and selected preferences (the cog).
Click the cog next to Jabber int he column header.
Enter 'admin2@localhost' and hit enter to link that user to student 1
Open messaging pane and click the cog
Enable Jabber output (toggle to on) but leave the Email (and any other outputs, if available) disabled (we don't want these to interfere for now)
Log out.
Download pidgin (sudo apt-get install pidgin)
Open pidgin and set up student 1's linked jabber account:
- Basic tab
  - Username: admin2
  - Domain: localhost
  - Password: password4321
- Advanced tab
  - Connection security: Use encryption if available
- Proxy tab
  - Proxy: No proxy
Leave Pidgin open
Now, log in to moodle as student 2
Open messaging, search for student 1 and send them a message.
Verify the message is sent in Moodle's UI without any error/debug popups
Verify you get a message in Pidgin with the message details.

Show

Regression test We need to make sure XMPPHP still works as expected after the upgrade. As the admin user, run the local jabber server ( https://hub.docker.com/r/rroemhild/ejabberd ) configured with 2 users, and no TLS. docker run --name "ejabberd" \ -p 5222 : 5222 \ -p 5269 : 5269 \ -p 5280 : 5280 \ -h 'xmpp.localhost' \ -e "XMPP_DOMAIN=localhost" \ -e "EJABBERD_ADMINS=admin@localhost admin2@localhost" \ -e "EJABBERD_USERS=admin@localhost:password1234 admin2@localhost:password4321" \ -e "TZ=Europe/Berlin" \ -e "EJABBERD_STARTTLS=false" rroemhild/ejabberd In Moodle, enable Jabber and configure the server details. Set: host: 'localhost' Jabber server: NOT SET Username: admin Password: password1234. Via 'Default notification preferences' (Site administration > Messaging > Notification settings) enable Jabber for offline AND online use for the 'Personal messages between users' row. Make sure the select is set to 'Permitted'. Create a course and enrol 2 students, student 1 and student 2. Log out. Log in as student 1. Click the notifications bell, and selected preferences (the cog). Click the cog next to Jabber int he column header. Enter 'admin2@localhost' and hit enter to link that user to student 1 Open messaging pane and click the cog Enable Jabber output (toggle to on) but leave the Email (and any other outputs, if available) disabled (we don't want these to interfere for now) Log out. Download pidgin (sudo apt-get install pidgin) Open pidgin and set up student 1's linked jabber account: Basic tab Username: admin2 Domain: localhost Password: password4321 Advanced tab Connection security: Use encryption if available Proxy tab Proxy: No proxy Leave Pidgin open Now, log in to moodle as student 2 Open messaging, search for student 1 and send them a message. Verify the message is sent in Moodle's UI without any error/debug popups Verify you get a message in Pidgin with the message details.

Story Points:
1
Sprint:
Internationals - 3.8 Sprint 2, International 4.0 - Sprint 7

Description

Options

Upgrade

XMPPHP /lib/jabber/ 0.1rc2-r77 2.2 No https://github.com/BirknerAlex/XMPPHP

Has been forked and moved. This is the most up-to-date fork I could find but whomever picks up this issue should confirm this.

Remove

Consider removing XMPPHP and the message_output_jabber plugin from core.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

screenshot-1.png
19 kB
12/Oct/20 6:53 PM
screenshot-2.png
14 kB
12/Oct/20 6:54 PM

Issue Links

has been marked as being related by

MDL-52359 Replace XMPP library in Moodle to something supported and move from core to message/output/jabber

Closed

Activity

People

Assignee:: Simey Lameze

Reporter:: Andrew Lyons

Peer reviewer:: Jun Pataleta

Integrator:: Adrian Greeve

Tester:: David Mudrák (@mudrd8mz)

Participants:: Adrian Greeve, Andrew Lyons, CiBoT, David Mudrák (@mudrd8mz), Jun Pataleta, Sara Arjona (@sarjona), Simey Lameze

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 29/May/19 9:13 AM

Updated:: 04/Nov/20 6:03 PM

Resolved:: 13/Oct/20 8:16 PM

Fix Release Date:: 9/Nov/20

Time Tracking

Estimated:

Remaining:

Logged:

1d 1h 29m