Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65743

Upgrade XMPPHP to latest version

    XMLWordPrintable

Details

    • MOODLE_38_STABLE
    • MOODLE_310_STABLE
    • MDL-65743-master
    • Hide
      Regression test

      We need to make sure XMPPHP still works as expected after the upgrade.

      1. As the admin user, run the local jabber server (https://hub.docker.com/r/rroemhild/ejabberd) configured with 2 users, and no TLS.

        docker run  --name "ejabberd" \
        -p 5222:5222   \
        -p 5269:5269   \
        -p 5280:5280   \
        -h 'xmpp.localhost'   \
        -e "XMPP_DOMAIN=localhost"  \
        -e "EJABBERD_ADMINS=admin@localhost admin2@localhost"   \
        -e "EJABBERD_USERS=admin@localhost:password1234 admin2@localhost:password4321"  \
        -e "TZ=Europe/Berlin"   \
        -e "EJABBERD_STARTTLS=false"  rroemhild/ejabberd
         

      2. In Moodle, enable Jabber and configure the server details. Set:
        • host: 'localhost'
        • Jabber server: NOT SET
        • Username: admin
        • Password: password1234.
      3. Via 'Default notification preferences' (Site administration > Messaging > Notification settings) enable Jabber for offline AND online use for the 'Personal messages between users' row. Make sure the select is set to 'Permitted'.
      4. Create a course and enrol 2 students, student 1 and student 2.
      5. Log out.
      6. Log in as student 1.
      7. Click the notifications bell, and selected preferences (the cog).
      8. Click the cog next to Jabber int he column header.
      9. Enter 'admin2@localhost' and hit enter to link that user to student 1
      10. Open messaging pane and click the cog
      11. Enable Jabber output (toggle to on) but leave the Email (and any other outputs, if available) disabled (we don't want these to interfere for now)
      12. Log out.
      13. Download pidgin (sudo apt-get install pidgin)
      14. Open pidgin and set up student 1's linked jabber account:
        • Basic tab
          • Username: admin2
          • Domain: localhost
          • Password: password4321
        • Advanced tab
          • Connection security: Use encryption if available
        • Proxy tab
          • Proxy: No proxy
      15. Leave Pidgin open
      16. Now, log in to moodle as student 2
      17. Open messaging, search for student 1 and send them a message.
      18. Verify the message is sent in Moodle's UI without any error/debug popups
      19. Verify you get a message in Pidgin with the message details.
      Show
      Regression test We need to make sure XMPPHP still works as expected after the upgrade. As the admin user, run the local jabber server ( https://hub.docker.com/r/rroemhild/ejabberd ) configured with 2 users, and no TLS. docker run --name "ejabberd" \ -p 5222 : 5222 \ -p 5269 : 5269 \ -p 5280 : 5280 \ -h 'xmpp.localhost' \ -e "XMPP_DOMAIN=localhost" \ -e "EJABBERD_ADMINS=admin@localhost admin2@localhost" \ -e "EJABBERD_USERS=admin@localhost:password1234 admin2@localhost:password4321" \ -e "TZ=Europe/Berlin" \ -e "EJABBERD_STARTTLS=false" rroemhild/ejabberd In Moodle, enable Jabber and configure the server details. Set: host: 'localhost' Jabber server: NOT SET Username: admin Password: password1234. Via 'Default notification preferences' (Site administration > Messaging > Notification settings) enable Jabber for offline AND online use for the 'Personal messages between users' row. Make sure the select is set to 'Permitted'. Create a course and enrol 2 students, student 1 and student 2. Log out. Log in as student 1. Click the notifications bell, and selected preferences (the cog). Click the cog next to Jabber int he column header. Enter 'admin2@localhost' and hit enter to link that user to student 1 Open messaging pane and click the cog Enable Jabber output (toggle to on) but leave the Email (and any other outputs, if available) disabled (we don't want these to interfere for now) Log out. Download pidgin (sudo apt-get install pidgin) Open pidgin and set up student 1's linked jabber account: Basic tab Username: admin2 Domain: localhost Password: password4321 Advanced tab Connection security: Use encryption if available Proxy tab Proxy: No proxy Leave Pidgin open Now, log in to moodle as student 2 Open messaging, search for student 1 and send them a message. Verify the message is sent in Moodle's UI without any error/debug popups Verify you get a message in Pidgin with the message details.
    • 1
    • Internationals - 3.8 Sprint 2, International 4.0 - Sprint 7

    Description

      Options

      Upgrade

      XMPPHP /lib/jabber/ 0.1rc2-r77 2.2 No https://github.com/BirknerAlex/XMPPHP

      Has been forked and moved. This is the most up-to-date fork I could find but whomever picks up this issue should confirm this.

      Remove

      Consider removing XMPPHP and the message_output_jabber plugin from core.

      Attachments

        1. screenshot-1.png
          19 kB
          David Mudrák (@mudrd8mz)
        2. screenshot-2.png
          14 kB
          David Mudrák (@mudrd8mz)

        Issue Links

          Activity

            People

              lameze Simey Lameze
              dobedobedoh Andrew Lyons
              Jun Pataleta Jun Pataleta
              Adrian Greeve Adrian Greeve
              David Mudrák (@mudrd8mz) David Mudrák (@mudrd8mz)
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/Nov/20

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 1 hour, 29 minutes
                  1d 1h 29m