Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65774

Upgrade FPDI to v2 API

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.8
    • Fix Version/s: 3.8
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide

      Copied instructions from previous upgrade.

      Run behat tests @assignfeedback_editpdf (CI will do this).

      For annotate pdf to work, please ensure that you have ghostscript installed on your system.

      1. Go to [Site administration ► Development ► Third party libraries] and check that FPDI is version 2.2.0.
      2. Create an assign activity.
        • In Feedback types make sure that 'Feedback comments' and 'Feedback files' are checked.
      3. As a student submit a PDF file.
      4. Log in as a teacher and grade the assignment.
      5. Launch the PDF editor.
      6. Add each of everything from the bar at the top.
      7. Save changes and make sure that no errors or warnings are produced.

       

      Run behat tests @assignfeedback_editpdf on php7.1 - to account for custom patches in MDL-55848 and MDL-60301

      Show
      Copied instructions from previous upgrade. Run behat tests @assignfeedback_editpdf (CI will do this). For annotate pdf to work, please ensure that you have ghostscript installed on your system. Go to [Site administration ► Development ► Third party libraries] and check that FPDI is version 2.2.0. Create an assign activity. In Feedback types make sure that 'Feedback comments' and 'Feedback files' are checked. As a student submit a PDF file. Log in as a teacher and grade the assignment. Launch the PDF editor. Add each of everything from the bar at the top. Save changes and make sure that no errors or warnings are produced.   Run behat tests @assignfeedback_editpdf on php7.1 - to account for custom patches in MDL-55848 and MDL-60301
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      MDL-65774-master2

      Attachments

        Issue Links

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/19

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 8 minutes
                2h 8m