Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65777

Downloading assignment submissions doesn't respect Alternate full name with viewfullnames capability

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.6.3
    • Fix Version/s: 3.6.5, 3.7.1
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as Admin.
      2. Create a new user account.
        • First name = 'Samuel'.
        • Last name = 'Student'.
        • Alternate name = 'Sammy'.
      3. Create a new Course.
      4. Access the Course and enrol Samuel Student.
      5. Create an Assignment.
        • Submission types
          • Online text
          • File submissions
      6. Feedback types
        • Enable "Feedback files"
      7. Log in as Samuel Student and submit a file (a text document for example).

      Scenario 1

      1. Log in as Admin.
      2. Navigate to the Assignment.
      3. Go to View/grade all submissions.
      4. Select all submissions.
      5. From Grading action select Download all submissions.
      6. View the file on your computer.
        • make sure the file name is prefixed with 'Samuel Student'.
      7. Navigate to Site admin > Users > Permissions > User policies and set Alternative full name format to 'alternatename lastname'.
      8. Navigate back to the Assignment.
      9. Go to View/grade all submissions.
      10. Select all submissions.
      11. From Grading action select Download all submissions.
      12. View the file on your computer.
        • make sure the file name is prefixed with 'Sammy Student'.

      Scenario 2 (Continue after finishing scenario 1)

      1. Go to the folder where the submissions were downloaded.
      2. Extract all the files from the zip to a new empty folder (Should only be one).
      3. Open and edit the document and save it.
      4. Select all files in the folder and create a new zip file from them. (Do not just zip the folder).
      5. Log in as Admin.
      6. Navigate to the Assignment.
      7. Go to View/grade all submissions.
      8. Choose "Upload multiple files in a zip" from the drop down menu above the grading table.
      9. Upload the new zip file.
        • make sure the notification message contains the alternative name (New/Modified feedback file "Teacher Course Roles.docx" for student "Sammy Student")
      10. You should see that there is one new feedback file - click "Confirm" to save the files.
      11. Go back to View/grade all submissions.
        • make sure that Sammy Student received a new feedback file and it is the correct file.

      Scenario 3

      1. Log in as Admin.
      2. Go to Site administration > Users > Permissions > Define roles
      3. Edit the Teacher role.
        • prohibit the "moodle/site:viewfullnames" capability.
      4. Enrol a Teacher in the Course.
      5. Repeat the steps from Scenario 1 and Scenario 2 this time logged in as Teacher.
        • make sure each time the name displayed is "Samuel Student".
      Show
      Log in as Admin. Create a new user account. First name = 'Samuel'. Last name = 'Student'. Alternate name = 'Sammy'. Create a new Course. Access the Course and enrol Samuel Student. Create an Assignment. Submission types Online text File submissions Feedback types Enable "Feedback files" Log in as Samuel Student and submit a file (a text document for example). Scenario 1 Log in as Admin. Navigate to the Assignment. Go to View/grade all submissions. Select all submissions. From Grading action select Download all submissions. View the file on your computer. make sure the file name is prefixed with 'Samuel Student'. Navigate to Site admin > Users > Permissions > User policies and set Alternative full name format to 'alternatename lastname'. Navigate back to the Assignment. Go to View/grade all submissions. Select all submissions. From Grading action select Download all submissions. View the file on your computer. make sure the file name is prefixed with 'Sammy Student'. Scenario 2 (Continue after finishing scenario 1) Go to the folder where the submissions were downloaded. Extract all the files from the zip to a new empty folder (Should only be one). Open and edit the document and save it. Select all files in the folder and create a new zip file from them. (Do not just zip the folder). Log in as Admin. Navigate to the Assignment. Go to View/grade all submissions. Choose "Upload multiple files in a zip" from the drop down menu above the grading table. Upload the new zip file. make sure the notification message contains the alternative name (New/Modified feedback file "Teacher Course Roles.docx" for student "Sammy Student") You should see that there is one new feedback file - click "Confirm" to save the files. Go back to View/grade all submissions. make sure that Sammy Student received a new feedback file and it is the correct file. Scenario 3 Log in as Admin. Go to Site administration > Users > Permissions > Define roles Edit the Teacher role. prohibit the " moodle/site:viewfullnames " capability. Enrol a Teacher in the Course. Repeat the steps from Scenario 1 and Scenario 2 this time logged in as Teacher. make sure each time the name displayed is "Samuel Student".
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull 3.6 Branch:
    • Pull 3.7 Branch:
    • Pull Master Branch:
      MDL-65777-master

      Description

      Replication steps

      1. Create account Samuel Student with alternate name 'Sammy'
      2. Navigate to Site admin>Permissions>User policies and set Alternative full name format to 'alternatename surname'
      3. Access any course and enrol Samuel Student
      4. Create an assignment with default settings
      5. Log in as Samuel Student and submit a file
      6. Return to admin view and view/grade all submissions
      7. From Grading action select Download all submissions
      8. View the file on your computer

      Observed behaviour

      File name is prefixed with 'Samuel Student'

      Expected behaviour

      File name is prefixed with 'Sammy Student'

      Additional notes

      • Same result regardless of downloading in folders or not
      • Users with the viewfullnames capability are shown the 'Alternative full name' format everywhere else. Downloading submissions should be consistent with this
      • Works as expected when modifying 'Full name format' in <site>/admin/settings.php?section=userpolicies. Suspect an extra check for the viewfullnames capability is needed prior to building the file/folder names.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/Jul/19

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 35 minutes
                3h 35m