Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65803

Invalid record error message from deleted item in recently accessed items block

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Unit tests provided.

      Setup
      1. Uninstall your current instance.
      2. Check out an older version of the branch that you're testing (e.g. if you're testing on 3.6, you can do git checkout v3.6.0)
      3. Install this Moodle instance
      4. Set up the following
        • 3 courses (C1, C2 and C3) with 2 forums in each of them
        • A user (admin is fine) enrolled in the courses
        • "Recently accessed items" (RAI) block added on the Dashboard
      5. As the user, go to each of the forums in the courses.
      6. Go to the dashboard and confirm the 6 forums appear in the RAI block
      7. Delete course C3
      8. Delete a forum from C2.
      Test 1 - Upgrade
      1. Checkout the branch that you're testing (e.g. if you're on 3.6, "git checkout MOODLE_36_STABLE")
      2. Upgrade your moodle instance.
      3. Confirm that upgrade completes successfully and you don't see any errors.
      4. Go to the Dashboard
      5. Confirm that you don't encounter any errors.
      6. Confirm that the forums from C3 are no longer being shown in the RAI block.
      7. Confirm that the forum that you deleted in C2 is no longer being shown in the RAI block.
      Test 2 - Deleting courses/activity modules
      1. Check the RAI block on your Dashboard. You should see 2 forums from C1 and a forum from C2.
      2. Delete course C2
      3. Delete a forum in C1
      4. Go back to the Dashboard
      5. Confirm that you don't encounter any errors.
      6. Confirm that the forum from C2 is no longer being shown in the RAI block.
      7. Confirm that the forum that you deleted in C1 is no longer being shown in the RAI block.
      Show
      Unit tests provided. Setup Uninstall your current instance. Check out an older version of the branch that you're testing (e.g. if you're testing on 3.6, you can do git checkout v3.6.0 ) Install this Moodle instance Set up the following 3 courses (C1, C2 and C3) with 2 forums in each of them A user (admin is fine) enrolled in the courses "Recently accessed items" (RAI) block added on the Dashboard As the user, go to each of the forums in the courses. Go to the dashboard and confirm the 6 forums appear in the RAI block Delete course C3 Delete a forum from C2. Test 1 - Upgrade Checkout the branch that you're testing (e.g. if you're on 3.6, " git checkout MOODLE_36_STABLE ") Upgrade your moodle instance. Confirm that upgrade completes successfully and you don't see any errors. Go to the Dashboard Confirm that you don't encounter any errors. Confirm that the forums from C3 are no longer being shown in the RAI block. Confirm that the forum that you deleted in C2 is no longer being shown in the RAI block. Test 2 - Deleting courses/activity modules Check the RAI block on your Dashboard. You should see 2 forums from C1 and a forum from C2. Delete course C2 Delete a forum in C1 Go back to the Dashboard Confirm that you don't encounter any errors. Confirm that the forum from C2 is no longer being shown in the RAI block. Confirm that the forum that you deleted in C1 is no longer being shown in the RAI block.
    • Affected Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull from Repository:
    • Pull 3.6 Branch:
    • Pull 3.7 Branch:
    • Pull Master Branch:
      MDL-65803-master

      Description

      As experienced on learn.moodle.net when a user logs in she first see the message in the screenshot. Closing the error message then allows her to continue as normal. It is believed this is due to the recently accessed items block trying to access a deleted item.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  8/Jul/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 6 hours
                  6h