Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65853

Labels should be consistently counted in progress

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      With the patch not applied (or reverted)
      1. Create a Topics based course with one section, course layout of one section per page and completion tracking turned on.
      2. Enrol yourself as a teacher on that course.
      3. Turn editing on.
      4. In the first section create a Book resource with one chapter, manual completion tracking on.
      5. Duplicate that Book activity to create another.
      6. In the first section create a label with the text 'Test' and manual completion tracking on.
      7. Turn editing off.
      8. Manually mark both book resources as complete.
      9. Navigate to the main course page.
      10. Observe that 'Topic 1' summary reports that there are two books and 'Progress' is 2 out of 2.  So 'logically' complete.
      11. Navigate to the 'Dashboard' containing the 'Course overview' block.
      12. Find the course in the list of courses (You may need to change the filter to 'All') and observe that the bar chart shows 66% complete.  Thus being logically different to the apparent 100% outcome in step 10.
      With the patch applied
      1. Create a Topics based course with one section, course layout of one section per page and completion tracking turned on.
      2. Enrol yourself as a teacher on that course.
      3. Turn editing on.
      4. In the first section create a Book resource with one chapter, manual completion tracking on.
      5. Duplicate that Book activity to create another.
      6. In the first section create a label with the text 'Test' and manual completion tracking on.
      7. Turn editing off.
      8. Manually mark both book resources as complete.
      9. Navigate to the main course page.
      10. Observe that 'Topic 1' summary reports that there are two books and one label and 'Progress' is 2 out of 3.  So 'logically' incomplete.
      11. Navigate to the 'Dashboard' containing the 'Course overview' block.
      12. Find the course in the list of courses (You may need to change the filter to 'All') and observe that the bar chart shows 66% complete.
      Show
      With the patch not applied (or reverted) Create a Topics based course with one section, course layout of one section per page and completion tracking turned on. Enrol yourself as a teacher on that course. Turn editing on. In the first section create a Book resource with one chapter, manual completion tracking on. Duplicate that Book activity to create another. In the first section create a label with the text 'Test' and manual completion tracking on. Turn editing off. Manually mark both book resources as complete. Navigate to the main course page. Observe that 'Topic 1' summary reports that there are two books and 'Progress' is 2 out of 2.  So 'logically' complete. Navigate to the 'Dashboard' containing the 'Course overview' block. Find the course in the list of courses (You may need to change the filter to 'All') and observe that the bar chart shows 66% complete.  Thus being logically different to the apparent 100% outcome in step 10. With the patch applied Create a Topics based course with one section, course layout of one section per page and completion tracking turned on. Enrol yourself as a teacher on that course. Turn editing on. In the first section create a Book resource with one chapter, manual completion tracking on. Duplicate that Book activity to create another. In the first section create a label with the text 'Test' and manual completion tracking on. Turn editing off. Manually mark both book resources as complete. Navigate to the main course page. Observe that 'Topic 1' summary reports that there are two books and one label and 'Progress' is 2 out of 3.  So 'logically' incomplete. Navigate to the 'Dashboard' containing the 'Course overview' block. Find the course in the list of courses (You may need to change the filter to 'All') and observe that the bar chart shows 66% complete.
    • Affected Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull from Repository:
    • Pull 3.6 Branch:
      MDL-65853_m36
    • Pull 3.7 Branch:
      MDL-65853_m37
    • Pull Master Branch:
      MDL-65853_master

      Description

      The method 'get_course_progress_percentage' in '/completion/classes/progress.php' does count 'labels' when calculating the percentage progress.  This is used 'indirectly via AJAX' in the MyOverview block.  The method 'section_activity_summary' in '/course/format/renderer.php' does not count 'labels' when calculating the percentage progress which is shown in the section summary.

      Therefore there is an inconsistency in the accuracy of the information being presented to the user.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/Jul/19

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 55 minutes
                1h 55m