Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65854

Locked/Disabled message notification setting doesn't represent actual value



    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.6.4, 3.7
    • Fix Version/s: None
    • Component/s: Administration, Messages
    • Labels:


      In the new Messaging drawer, in the settings, if a Notification processor setting is locked or disabled, it doesn't necessarily show the effective value.

      Take attached screenshot - the Email setting is Locked (which effectively means forced on) but it shows as off here.


      The main way this can happen is if the user picked a setting (on or off) before the setting was set to Locked or Disabled. I think there is also a way to do it by changing the on-off setting of other preferences, but I'm not sure right now.

      I feel the locked element should reflect the effective state, not the state the user last left it in.  Especially since Locked implied it is in the state you see, but you can't change it, it really means 'Forced on'.


      A note to watch out for that I found while researching this:

      If we show the setting in its effective state when Locked/Disabled, we will need to be careful to not overwrite the user's previous setting when they change a different setting. This is because the bit of code that saves the settings to the user preferences still obeys the submitted values for locked/disabled setting. In fact, you can edit the checked attribute of the disabled field in your browser, then change a different notification preference, and that change you made will be reflected in the user preferences table.

      So if we aren't careful, if the user makes other changes, their preferred setting would get overwritten with the current locked/disabled setting.






            • Assignee:
              emerrill Eric Merrill
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            • Votes:
              0 Vote for this issue
              2 Start watching this issue


              • Created:

                Time Tracking

                Original Estimate - Not Specified
                Not Specified
                Remaining Estimate - 0 minutes
                Time Spent - 5 minutes