Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65878

Adapt "Move discussion to…" chooser and button to look like formats choose pulldown and button

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.6.6, 3.7, 3.8
    • Fix Version/s: 3.6.7, 3.7.3
    • Component/s: Forum
    • Labels:
    • Testing Instructions:
      Hide

      Note: Test everything with clean and boost (36_STABLE), classic and boost (37_STABLE and master)

      Normal browser test.

      1. Go to Site administration > Advanced features and Enable portfolios
      2. Go to Site administration > Plugins > Portfolios > Manage portfolios and enable "File download" enabled and visible as well as a second option enabled and visible.
      3. Create a course
      4. Insert two forums to your course
      5. Add a topic to one of the forums and then go to that topic
      6. Verify the "Move this discusson to…" chooser "Move" button isn't sticky to the select field any more.
      7. Also verify that the "Export whole discussion to portfolio" button isn't sticky to the select field any more.

      Note this is simular to the slight visual change introduced in MDL-65387.

      With Javascript disabled

      1. Disable JavaScript (for Chrome and current session it can be done this way)
      2. Reload the forum topic page.
      3. Verify the "Move this discusson to…" chooser "Move" button isn't sticky to the select field any more.
      4. Verify the "Display replies in nested form…" chooser "Go" button isn't sticky to the select field any more.
      5. Also verify that the "Export whole discussion to portfolio" button isn't sticky to the select field any more.

       

      Show
      Note: Test everything with clean and boost (36_STABLE), classic and boost (37_STABLE and master) Normal browser test. Go to Site administration > Advanced features and Enable portfolios Go to Site administration > Plugins > Portfolios > Manage portfolios and enable "File download" enabled and visible as well as a second option enabled and visible. Create a course Insert two forums to your course Add a topic to one of the forums and then go to that topic Verify the "Move this discusson to…" chooser "Move" button isn't sticky to the select field any more. Also verify that the "Export whole discussion to portfolio" button isn't sticky to the select field any more. Note this is simular to the slight visual change introduced in MDL-65387 . With Javascript disabled Disable JavaScript (for Chrome and current session it can be done this way ) Reload the forum topic page. Verify the "Move this discusson to…" chooser "Move" button isn't sticky to the select field any more. Verify the "Display replies in nested form…" chooser "Go" button isn't sticky to the select field any more. Also verify that the "Export whole discussion to portfolio" button isn't sticky to the select field any more.  
    • Affected Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull from Repository:
    • Pull 3.6 Branch:
    • Pull 3.7 Branch:
    • Pull Master Branch:
      MDL-65878-master

      Description

      In forum, "Move discussion to…" chooser and button to as well as "File download" chooser and button are displayed alongside each other but do look different.

      To reproduce: go to e.g. https://qa.moodle.net/mod/forum/discuss.php?d=2

        Attachments

        1. 36_failed_MDL-65878_02.png
          36_failed_MDL-65878_02.png
          63 kB
        2. 36_failed_MDL-65878.png
          36_failed_MDL-65878.png
          85 kB
        3. 36stable_results.png
          36stable_results.png
          71 kB
        4. 37_master_passed_MDL-65878.png
          37_master_passed_MDL-65878.png
          67 kB
        5. MDL-65878.png
          MDL-65878.png
          95 kB
        6. MDL-65878-after.png
          MDL-65878-after.png
          86 kB
        7. MDL-65878-single_select.png
          MDL-65878-single_select.png
          83 kB
        8. Screen Shot 2019-08-26 at 4.10.33 pm.png
          Screen Shot 2019-08-26 at 4.10.33 pm.png
          12 kB

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 36 minutes
                  2h 36m