[MDL-65904] CSS fallback uses parents in incorrect order - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.6.4, 3.7
Fix Version/s: 3.6.5, 3.7.1
Component/s: Themes
Labels:
- ci
- patch
- triaged

Affected Branches:
MOODLE_36_STABLE, MOODLE_37_STABLE
Fixed Branches:
MOODLE_36_STABLE, MOODLE_37_STABLE
Pull from Repository:
git://github.com/merrill-oakland/moodle.git
Pull Master Branch:
~~MDL-65904~~-master
Pull Master Diff URL:
https://github.com/merrill-oakland/moodle/compare/f3507273e9...MDL-65904-master
Testing Instructions:
Hide

This can be tested just with Classic and Boost, although it is a bit subtle.

Go to Setup a test site and select Classic as the active theme.

Go to the Users dashboard, confirm that the dashboard is made of grey cards on a white background.

Go to the Classic settings (Site Admin > Appearance > Themes > Classic.

Go to the Advanced tab.

In Raw initial SCSS enter $foo: $bar;

Save. If you have debugging on, you should see a "Error while compiling SCSS" message in your PHP log. The error will not display in browser.

Go back to the user dashboard.

Reload (Sometimes an additional page reload is needed to get the latest CSS, unrelated to this issue).

Confirm that the dashboard is made of grey cards (blocks) on a white background.

The old behavior would have resulted in there being white cards on a gray background, which is the Boost aesthetic.
Show
This can be tested just with Classic and Boost, although it is a bit subtle. Go to Setup a test site and select Classic as the active theme. Go to the Users dashboard, confirm that the dashboard is made of grey cards on a white background. Go to the Classic settings (Site Admin > Appearance > Themes > Classic. Go to the Advanced tab. In Raw initial SCSS enter $foo: $bar; Save. If you have debugging on, you should see a "Error while compiling SCSS" message in your PHP log. The error will not display in browser. Go back to the user dashboard. Reload (Sometimes an additional page reload is needed to get the latest CSS, unrelated to this issue). Confirm that the dashboard is made of grey cards (blocks) on a white background. The old behavior would have resulted in there being white cards on a gray background, which is the Boost aesthetic.

Description

If using precompiledcsscallback in a child theme of a parent that also implements it, the parent's fallback css will effectively override the child css.

This is because the the theme_config->get_precompiled_css_content() stitches the CSS files together in child + parents order, resulting in parents CSS being lower in the CSS, hence taking higher priority for identical specificity.

As other areas of the lib do, it should be in array_reverse(parents) + child order.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-65904.jpg
35 kB
20/Jun/19 9:18 AM

Issue Links

has been marked as being related by

MDL-59261 Add a shipped version of core themes as a final fallback for CSS

Closed

Activity

People

Assignee:: Eric Merrill

Reporter:: Eric Merrill

Peer reviewer:: Ryan Wyllie

Integrator:: Jake Dallimore

Tester:: Anna Carissa Sadia

Participants:: Anna Carissa Sadia, CiBoT, Eric Merrill, Jake Dallimore, Ryan Wyllie

Component watchers:: Huong Nguyen, Bas Brands, Mathew May

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 13/Jun/19 12:44 AM

Updated:: 21/Jun/19 12:00 AM

Resolved:: 21/Jun/19 12:00 AM

Fix Release Date:: 8/Jul/19

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

2h 10m