Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65908

Annotated PDF - Comments can't be added and viewed in RTL user interface

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Pre-requisites

      1. Make sure that a document converter is installed and working on your site (i.e. Unoconv)
      2. Install a Right-to-Left(RTL) language pack e.g. Arabic (https://docs.moodle.org/37/en/Language_packs)

      Setup

      1. Create a course with a teacher enrolled in it with the "editing teacher" role and a student enrolled with the student role. 

      Test

      Original test from 65484
      1. Log in as the teacher and create an assignment with online text submissions and "Annotate PDF" feedback enabled.
      2. From the "View all submissions" page for the assignment, edit the students submission to add at least 2 pages of text.
      3. As a teacher, grade the submission and add one of each of these annotations to the top of each submission page.
        1. Text comment
        2. Squiggly line
        3. Straight line
        4. Rectangle
        5. Circle
        6. Highlighter box
        7. Stamp
      4. Return to the "View all submissions" page for the assignment
      5. Click on the "View the Annotated PDF..." link for the submission.
      6. Visit each page of the annotated PDF and scroll the document down.
      7. On each page, verify none of the annotations are displayed outside of the scrollable region for the feedback document (see the screenshot image on this issue for an example of a fail).
      RTL test(contd from previous)
      1. As a teacher, grade the submission from the previous test
      2. Switch to the RTL language
      3. Confirm you can see the previously added annotations.
      4. Confirm you can add one of each of the annotations:
        1. Text comment - text entered should be right aligned and begin from the right
        2. Squiggly line
        3. Straight line
        4. Rectangle
        5. Circle
        6. Highlighter box
        7. Stamp
      5. Return to the "View all submissions" page for the assignment
      6. Click on the "View the Annotated PDF..." link for the submission.
      7. Visit each page of the annotated PDF and scroll the document down.
      8. On each page, verify none of the annotations are displayed outside of the scrollable region for the feedback document (see this for an example of a fail).
      Resize test
      1. Using both a RTL and a LTR language
        1. Resize the browser and confirm that the annotations location adjust for the change in viewport and remain in the original spot. Specifically test with horizontal scroll.
      Show
      Pre-requisites Make sure that a document converter is installed and working on your site (i.e. Unoconv) Install a Right-to-Left(RTL) language pack e.g. Arabic ( https://docs.moodle.org/37/en/Language_packs ) Setup Create a course with a teacher enrolled in it with the "editing teacher" role and a student enrolled with the student role.  Test Original test from 65484 Log in as the teacher and create an assignment with online text submissions and "Annotate PDF" feedback enabled. From the "View all submissions" page for the assignment, edit the students submission to add at least 2 pages of text. As a teacher, grade the submission and add one of each of these annotations to the top of each submission page. Text comment Squiggly line Straight line Rectangle Circle Highlighter box Stamp Return to the "View all submissions" page for the assignment Click on the "View the Annotated PDF..." link for the submission. Visit each page of the annotated PDF and scroll the document down. On each page, verify none of the annotations are displayed outside of the scrollable region for the feedback document (see the screenshot image on this issue for an example of a fail). RTL test(contd from previous) As a teacher, grade the submission from the previous test Switch to the RTL language Confirm you can see the previously added annotations. Confirm you can add one of each of the annotations: Text comment - text entered should be right aligned and begin from the right Squiggly line Straight line Rectangle Circle Highlighter box Stamp Return to the "View all submissions" page for the assignment Click on the "View the Annotated PDF..." link for the submission. Visit each page of the annotated PDF and scroll the document down. On each page, verify none of the annotations are displayed outside of the scrollable region for the feedback document (see this for an example of a fail). Resize test Using both a RTL and a LTR language Resize the browser and confirm that the annotations location adjust for the change in viewport and remain in the original spot. Specifically test with horizontal scroll.
    • Affected Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull from Repository:
    • Pull 3.6 Branch:
    • Pull 3.7 Branch:
    • Pull Master Branch:
      MDL-65908-master

      Description

      Please note that this bug relates only to Right-to-left UI environments.

       

      Repro Steps

      1. Login to the Moodle environment
      2. Switch to the English UI.
      3. Login as a teacher and create an assignment.
      4. Login as a student and submit a document.
      5. Login again as a teacher, enter the assignment and the submissions table,  and click the "Grade"button at the row of the student that submitted the document.
      6. Add some comments to the submission using the "Comment" tool (in the "Annotated PDF" component window).
      7. Verify that comments can be added and viewed after they are added.
      8. Switch to the Arabic or Hebrew UI (or any other RTL UI).
      9. Notice that the already added comments are gone.
      10. Try to add a new comment.

       

      Actual Results

      1. A comment can't be added when using RTL UI.
      2. Already added comments can't be viewed when using RTL UI.

       

      Expected Results

      1. A comment could be added when using RTL UI.
      2. Already added comments could be viewed when using RTL UI.

       

        Attachments

        1. MDL-65908.jpg
          MDL-65908.jpg
          88 kB
        2. MDL-65908 (2).jpg
          MDL-65908 (2).jpg
          101 kB
        3. MDL-65908 (3).jpg
          MDL-65908 (3).jpg
          73 kB
        4. MDL-65908 (4).jpg
          MDL-65908 (4).jpg
          65 kB

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Sep/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 4 hours
                  1d 4h