Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65925

Grade page is broken if submission other than PDF was deleted

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Log in as a teacher in a course.
      2. Create an assignment with the following settings:
        Submission types File submissions
        Maximum number of uploaded files 2 (or more)
        Feedback types Annotate PDF
        Require students to click the submit button Yes
        Attempts reopened Manually
        Maximum attempts Unlimited
      3. On another browser (e.g. incognito window), login as student and upload pdf file to assignment.
      4. Save the changes, but do not press "Submit assignment" to leave its status as "Draft".
      5. Back on the teacher's window, go to grading page and grade the student's submission.
      6. Make sure PDF feedback is successfully generated. Press "Save changes".
      7. Back on the student's window, upload another file to assignment in docx format. Save the changes but don't submit it.
      8. Back on the teacher's window, refresh the grading page. Make sure PDF feedback is successfully generated. Press "Save changes".
      9. Back on the student's browser and delete the docx file from assignment submission.  Save the changes don't submit it.
      10. Back on the teacher's window, refresh the grading page.
      11. Confirm that the PDF feedback is successfully generated and that the page is not stuck trying to generate the PDF.
      Show
      Log in as a teacher in a course. Create an assignment with the following settings: Submission types File submissions Maximum number of uploaded files 2 (or more) Feedback types Annotate PDF Require students to click the submit button Yes Attempts reopened Manually Maximum attempts Unlimited On another browser (e.g. incognito window), login as student and upload pdf file to assignment. Save the changes, but do not press " Submit assignment " to leave its status as " Draft ". Back on the teacher's window, go to grading page and grade the student's submission. Make sure PDF feedback is successfully generated. Press " Save changes ". Back on the student's window, upload another file to assignment in docx format. Save the changes but don't submit it. Back on the teacher's window, refresh the grading page. Make sure PDF feedback is successfully generated. Press " Save changes ". Back on the student's browser and delete the docx file from assignment submission.  Save the changes don't submit it. Back on the teacher's window, refresh the grading page. Confirm that the PDF feedback is successfully generated and that the page is not stuck trying to generate the PDF.
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
      MDL-65925-grade-page-broken-for-deleted-submission-MOODLE_35_STABLE
    • Pull 3.5 Diff URL:
    • Pull Master Branch:
      MDL-65925-grade-page-broken-for-deleted-submission-master
    • Pull Master Diff URL:

      Description

      Just  found that if student uploads multiple files to assigment (pdf and docx) and deletes docx later, then grading page will be broken for him (when annotate PDF is enabled). A page will stuck in infinit loop doing bunch of requests like

      http://localhost/mod/assign/feedback/editpdf/ajax.php?sesskey=2yzbUXKwBN&action=pollconversions&userid=56&attemptnumber=0&assignmentid=5&readonly=0

        Attachments

        1. Assignment.png
          Assignment.png
          264 kB
        2. MDL-65925.png
          MDL-65925.png
          266 kB
        3. partial_assign.png
          partial_assign.png
          118 kB
        4. poodll3.png
          poodll3.png
          78 kB

          Issue Links

          is a regression caused by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-60008 File won't render in the grader if both submission types are selected

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-64540 Backport MDL-60008 - File won't render in the grader if both submission types are selected

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              ilyatregubov Ilya Tregubov
              Reporter:
              ilyatregubov Ilya Tregubov
              Peer reviewer:
              Matt Porritt
              Integrator:
              Jun Pataleta
              Tester:
              Jennifer Bauzon
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              2 Vote for this issue
              Watchers:
              13 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Sep/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 6 hours, 45 minutes
                  6h 45m