Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65936

Duplicate Font-awesome in /lib

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.7
    • Fix Version/s: 3.8
    • Component/s: Libraries, Themes
    • Labels:
    • Sprint:
      Internationals - 3.8 Sprint 2

      Description

      It has been discovered that in MDL-40759 the Font Awesome SCSS has been included into Moodle core twice.

      The actively used SCSS is in /theme/boost/scss/fontawesome/.scss

      whereas this SCSS lives in /lib/fonts/font-awesome-4.7.0/.scss

       I'll attach a patch file for master only as this will be a library change. If integrators wish for this to be backported I can create the branches as required.

        Attachments

        1. screenshot-1.png
          187 kB
          Janelle Barcega
        2. test.php
          1 kB
          Mathew May

          Issue Links

            Activity

              People

              Assignee:
              mathewmay Mathew May
              Reporter:
              mathewmay Mathew May
              Peer reviewer:
              Mihail Geshoski
              Integrator:
              Andrew Nicols
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 20 minutes
                  2h 20m