Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65941

Redis server issues break cache configuration page

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Waiting for peer review
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.6.4, 3.7
    • Fix Version/s: None
    • Component/s: Caching
    • Labels:
    • Testing Instructions:
      Hide
      1. Create a redis cache instance. Confirm that it shows as "ready".
      2. Kill the redis server (either kill the process, or the container)
      3. Go back to the cache page.
      4. Confirm that you don't see an error message (either "Connection refused" or "getaddrinfo failed" depending on what you did in step 2)
      5. Confirm that your redis instance is not marked as ready
      Show
      Create a redis cache instance. Confirm that it shows as "ready". Kill the redis server (either kill the process, or the container) Go back to the cache page. Confirm that you don't see an error message (either "Connection refused" or "getaddrinfo failed" depending on what you did in step 2) Confirm that your redis instance is not marked as ready
    • Affected Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull 3.7 Branch:
      MDL-65941-m37
    • Pull Master Branch:

      Description

      If you have an instance of the redis cache store, and Moodle is unable to connect to the redis server, the cache configuration page fails with an exception. This is unlike the behaviour of other stores, like memcached, where the instance is simply marked as "not ready" if the server can't be contacted.

      This is potentially a pretty serious issue for server administrators as it makes it impossible to switch to another cache store while a redis server is unavailable.

      To reproduce (with a working redis server):

      1. Create a redis cache instance. Confirm that it shows as "ready".
      2. Kill the redis server (either kill the process, or the container)
      3. Go back to the cache page.
      4. You will see an error message (either "Connection refused" or "getaddrinfo failed" depending on what you did in step 2) and be unable to edit your cache configuration.

      I'm seeing this with versions 4.1.1 and 4.3.0 of the redis plugin.

        Attachments

          Activity

            People

            Assignee:
            maherne Michael Aherne
            Reporter:
            maherne Michael Aherne
            Participants:
            Component watchers:
            Matteo Scaramuccia, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            4 Vote for this issue
            Watchers:
            9 Start watching this issue

              Dates

              Created:
              Updated: