Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65952

mod_scorm automatically checks "passed" and "completed" completion options

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Waiting for peer review
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.5.4, 3.6.4, 3.7
    • Fix Version/s: None
    • Component/s: SCORM
    • Labels:
    • Testing Instructions:
      Hide

      As a teacher:
      Add a scorm package that returns a grade,
      ( /mod/scorm/tests/packages/RuntimeMinimumCalls_SCORM12.zip is an easy example package)
      set activity completion rules to require a minimum grade of 40 (make sure passed and complete are not checked.)

      As a student:
      Enter the SCORM package and complete the scorm by obtaining a grade higher than 40 - (make sure activity completion box is checked.)

       

      As a teacher:
      Edit the settings of the SCORM package, make sure activity completion rules are locked with the message "Completion options locked" - Do not change any settings, but Save the page.

      Edit the settings of the SCORM package and make sure the require status "passed" and "complete" checkboxes are still left unticked.

       

      Show
      As a teacher: Add a scorm package that returns a grade, ( /mod/scorm/tests/packages/RuntimeMinimumCalls_SCORM12.zip is an easy example package) set activity completion rules to require a minimum grade of 40 (make sure passed and complete are not checked.) As a student: Enter the SCORM package and complete the scorm by obtaining a grade higher than 40 - (make sure activity completion box is checked.)   As a teacher: Edit the settings of the SCORM package, make sure activity completion rules are locked with the message "Completion options locked" - Do not change any settings, but Save the page. Edit the settings of the SCORM package and make sure the require status "passed" and "complete" checkboxes are still left unticked.  
    • Workaround:
      Hide

      I patched mod_form.php to make sure that completionstatusrequired array values are true before adding them to the total

      Show
      I patched mod_form.php to make sure that completionstatusrequired array values are true before adding them to the total
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull from Repository:
    • Pull 3.6 Branch:
      MDL-65952_m36
    • Pull 3.6 Diff URL:
    • Pull 3.7 Branch:
      MDL-65952_m37
    • Pull 3.7 Diff URL:
    • Pull Master Branch:
      master
    • Pull Master Diff URL:

      Description

      Steps : 

      • I open some SCORM settings where activity completion is enabled, the only requirement is 100 as minimum score, the activity has been marked as completed for participants so completion options are locked
      • I save the settings
      • I open the settings again, "passed" and "completed" are checked

      It only happens if completion options are locked.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              fabien.dallet Fabien Dallet
              Participants:
              Component watchers:
              Damyon Wiese, Dan Marsden, Matteo Scaramuccia, Adrian Greeve, Mihail Geshoski, Peter Dias
            • Votes:
              2 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated: