[MDL-65952] mod_scorm automatically checks "passed" and "completed" completion options - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.5.4, 3.6.4, 3.7, 3.7.4, 3.8.1
Fix Version/s: 3.7.5, 3.8.2
Component/s: SCORM
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
Fixed Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE
Pull from Repository:
https://github.com/fabiendallet/moodle.git
Pull Master Branch:
~~MDL-65952~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...fabiendallet:MDL-65952
Workaround:

Hide

I patched mod_form.php to make sure that completionstatusrequired array values are true before adding them to the total

Show
I patched mod_form.php to make sure that completionstatusrequired array values are true before adding them to the total
Testing Instructions:

Hide

As a teacher:
Add a scorm package that returns a grade,
( /mod/scorm/tests/packages/RuntimeMinimumCalls_SCORM12.zip is an easy example package)
set activity completion rules to require a minimum grade of 40 (make sure passed and complete are not checked.)

As a student:
Enter the SCORM package and complete the scorm by obtaining a grade higher than 40 - (make sure activity completion box is checked.)

As a teacher:
Edit the settings of the SCORM package, make sure activity completion rules are locked with the message "Completion options locked" - Do not change any settings, but Save the page.

Edit the settings of the SCORM package and make sure the require status "passed" and "complete" checkboxes are still left unticked.

Show
As a teacher: Add a scorm package that returns a grade, ( /mod/scorm/tests/packages/RuntimeMinimumCalls_SCORM12.zip is an easy example package) set activity completion rules to require a minimum grade of 40 (make sure passed and complete are not checked.) As a student: Enter the SCORM package and complete the scorm by obtaining a grade higher than 40 - (make sure activity completion box is checked.) As a teacher: Edit the settings of the SCORM package, make sure activity completion rules are locked with the message "Completion options locked" - Do not change any settings, but Save the page. Edit the settings of the SCORM package and make sure the require status "passed" and "complete" checkboxes are still left unticked.

Description

Steps :

I open some SCORM settings where activity completion is enabled, the only requirement is 100 as minimum score, the activity has been marked as completed for participants so completion options are locked
I save the settings
I open the settings again, "passed" and "completed" are checked

It only happens if completion options are locked.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

image-2020-01-23-12-56-09-755.png
49 kB
23/Jan/20 12:56 PM
mod_form.php
26 kB
18/Jun/19 8:48 PM

Activity

People

Assignee:: Fabien Dallet

Reporter:: Fabien Dallet

Peer reviewer:: Simey Lameze

Integrator:: Jun Pataleta

Tester:: Janelle Barcega

Participants:: CiBoT, Dan Marsden, Eloy Lafuente (stronk7), Fabien Dallet, Janelle Barcega, Jun Pataleta, Simey Lameze

Component watchers:: Dan Marsden, Matteo Scaramuccia, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan

Votes:: 4 Vote for this issue

Watchers:: 11 Start watching this issue

Dates

Created:: 18/Jun/19 8:45 PM

Updated:: 04/Mar/20 5:48 PM

Resolved:: 24/Jan/20 10:50 AM

Fix Release Date:: 9/Mar/20

Time Tracking

Estimated:

Remaining:

Logged: