Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65952

mod_scorm automatically checks "passed" and "completed" completion options

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5.4, 3.6.4, 3.7, 3.7.4, 3.8.1
    • Fix Version/s: 3.7.5, 3.8.2
    • Component/s: SCORM
    • Testing Instructions:
      Hide

      As a teacher:
      Add a scorm package that returns a grade,
      ( /mod/scorm/tests/packages/RuntimeMinimumCalls_SCORM12.zip is an easy example package)
      set activity completion rules to require a minimum grade of 40 (make sure passed and complete are not checked.)

      As a student:
      Enter the SCORM package and complete the scorm by obtaining a grade higher than 40 - (make sure activity completion box is checked.)

       

      As a teacher:
      Edit the settings of the SCORM package, make sure activity completion rules are locked with the message "Completion options locked" - Do not change any settings, but Save the page.

      Edit the settings of the SCORM package and make sure the require status "passed" and "complete" checkboxes are still left unticked.

       

      Show
      As a teacher: Add a scorm package that returns a grade, ( /mod/scorm/tests/packages/RuntimeMinimumCalls_SCORM12.zip is an easy example package) set activity completion rules to require a minimum grade of 40 (make sure passed and complete are not checked.) As a student: Enter the SCORM package and complete the scorm by obtaining a grade higher than 40 - (make sure activity completion box is checked.)   As a teacher: Edit the settings of the SCORM package, make sure activity completion rules are locked with the message "Completion options locked" - Do not change any settings, but Save the page. Edit the settings of the SCORM package and make sure the require status "passed" and "complete" checkboxes are still left unticked.  
    • Workaround:
      Hide

      I patched mod_form.php to make sure that completionstatusrequired array values are true before adding them to the total

      Show
      I patched mod_form.php to make sure that completionstatusrequired array values are true before adding them to the total
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      Steps : 

      • I open some SCORM settings where activity completion is enabled, the only requirement is 100 as minimum score, the activity has been marked as completed for participants so completion options are locked
      • I save the settings
      • I open the settings again, "passed" and "completed" are checked

      It only happens if completion options are locked.

        Attachments

          Activity

            People

            Assignee:
            fabien.dallet Fabien Dallet
            Reporter:
            fabien.dallet Fabien Dallet
            Peer reviewer:
            Simey Lameze Simey Lameze
            Integrator:
            Jun Pataleta Jun Pataleta
            Tester:
            Janelle Barcega Janelle Barcega
            Participants:
            Component watchers:
            Damyon Wiese, Dan Marsden, Matteo Scaramuccia, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            4 Vote for this issue
            Watchers:
            11 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              9/Mar/20

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 5 hours
                5h