Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65970

CURL requests to Airnotifier (Push notification server) when delivering notifications do not implement a time out

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.7
    • Fix Version/s: 3.6.7, 3.7.3
    • Component/s: Messages
    • Labels:
    • Testing Instructions:
      Hide
      Prerequisite
      1. Must be tested by someone from the Apps team with access to an Airnotifier staging instance
      Test
      1. Generate messaging (conversations) Push notifications are check that are delivered on time
      2. Create a forum with forced subscription in a course with more than 4 users with Mobile notifications enabled in real devices.
      3. Execute manually the cron after 30 minutes and check that the notifications are delivered on time
      4. Edit the Airnotifier /api/v2/push/ code to pause the execution of the script during 5 seconds
      5. Generate new Push notifications and check that they don't arrive (Moodle timeout skip them)
      Show
      Prerequisite Must be tested by someone from the Apps team with access to an Airnotifier staging instance Test Generate messaging (conversations) Push notifications are check that are delivered on time Create a forum with forced subscription in a course with more than 4 users with Mobile notifications enabled in real devices. Execute manually the cron after 30 minutes and check that the notifications are delivered on time Edit the Airnotifier /api/v2/push/ code to pause the execution of the script during 5 seconds Generate new Push notifications and check that they don't arrive (Moodle timeout skip them)
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull from Repository:
    • Pull 3.6 Branch:
    • Pull 3.7 Branch:
    • Pull Master Branch:
      MDL-65970-master

      Description

      If the server is unresponsive, we can have a connection open until the default timeout time is reached.

      When Airnotifier sends a notification to Firebase, it only waits for two seconds, we should do the same for notifications being sent from a Moodle site to Airnotifier to not block the script execution.

        Attachments

          Activity

            People

            • Assignee:
              jleyva Juan Leyva
              Reporter:
              jleyva Juan Leyva
              Peer reviewer:
              Dani Palou
              Integrator:
              Jake Dallimore
              Tester:
              Pau Ferrer
              Participants:
              Component watchers:
              Jake Dallimore, Jun Pataleta, Ryan Wyllie
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Nov/19

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 5 minutes
                2h 5m