Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65971

Reuse previously analysed analysables is not reusing anything

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Waiting for peer review
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.7
    • Fix Version/s: None
    • Component/s: Analytics
    • Labels:
    • Testing Instructions:
      Hide

      Prerequisites

      1. Add the following line right after public static function get_evaluation_analysable_file($modelid, $analysableid, $timesplittingid) { in analytics/classes/dataset_manager.php

        debugging('this is the model id: ' . $modelid);die();
        

      Test

      1. Enable debugging mode
      2. Log in as admin
      3. Enable 'onlycli' setting in site admin > analytics > analytics settings
      4. Enable 'enablecompletion' in site admin > advanced features
      5. Setup your timezone correctly in site admin > location > location settings
      6. Set up a course so that:
        • It uses topics format
        • completion is enabled
        • startdate to right now (including hour and minute)
      7. Enrol 2 users as students
      8. Enrol the logged in admin user as a course teacher
      9. We need the course to have a lesson activity in a course section different than section 0, if you don't have any add a lesson activity with a single content page, the content page jump should be "End of lesson".
        1. Set the "Expected completed on" time (in Activity completion fieldset) to right now (including hour and minute)
      10. Complete the lesson for each of the 2 users enrolled as students
      11. Set the course end date to right now
      12. Click on the course admin cog and select Course completion
      13. Set Condition: Manual completion by others to Teacher role
      14. Go to course admin > more... > reports > course completion
      15. Flag just one of the students as approved
      16. Run cron so that the course completion status of the student is updated
      17. Go to site admin > analytics > analytics models
      18. Click on new model > create model
      19. Set the following values in the form:
        1. Tick 'enabled'
        2. Target: Students at risk of not meeting the course completion conditions
        3. Indicators: Lesson cognitive
        4. Analysis interval: No time limits
        5. Default value for predictions processor
        6. Save changes
      20. Execute "Evaluate (using the current time-splitting method)" for the model you just created.
      21. You SHOULD just see one debugging message with the message this is the model id: I_AM_AN_INT (where I_AM_AN_INT is an int). The die() call would prevent the following code to be executed.
      Show
      Prerequisites Add the following line right after public static function get_evaluation_analysable_file($modelid, $analysableid, $timesplittingid) { in analytics/classes/dataset_manager.php debugging('this is the model id: ' . $modelid);die(); Test Enable debugging mode Log in as admin Enable 'onlycli' setting in site admin > analytics > analytics settings Enable 'enablecompletion' in site admin > advanced features Setup your timezone correctly in site admin > location > location settings Set up a course so that: It uses topics format completion is enabled startdate to right now (including hour and minute) Enrol 2 users as students Enrol the logged in admin user as a course teacher We need the course to have a lesson activity in a course section different than section 0, if you don't have any add a lesson activity with a single content page, the content page jump should be "End of lesson". Set the "Expected completed on" time (in Activity completion fieldset) to right now (including hour and minute) Complete the lesson for each of the 2 users enrolled as students Set the course end date to right now Click on the course admin cog and select Course completion Set Condition: Manual completion by others to Teacher role Go to course admin > more... > reports > course completion Flag just one of the students as approved Run cron so that the course completion status of the student is updated Go to site admin > analytics > analytics models Click on new model > create model Set the following values in the form: Tick 'enabled' Target: Students at risk of not meeting the course completion conditions Indicators: Lesson cognitive Analysis interval: No time limits Default value for predictions processor Save changes Execute "Evaluate (using the current time-splitting method)" for the model you just created. You SHOULD just see one debugging message with the message this is the model id: I_AM_AN_INT (where I_AM_AN_INT is an int). The die() call would prevent the following code to be executed.
    • Affected Branches:
      MOODLE_37_STABLE
    • Pull from Repository:
    • Pull 3.7 Branch:
    • Pull Master Branch:
      MDL-65971_master

      Description

      The evaluation process includes a --reuse-prev-analysed option to reuse previously analysed elements. This setting is not working since 3.7.0

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              dmonllao David Monllaó
              Participants:
              Component watchers:
              Elizabeth Dalton, David Monllaó
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours
                2h