Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66008

Calendar event form loading calls calendar_get_allowed_event_types() twice

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.7
    • Fix Version/s: 3.8
    • Component/s: Calendar
    • Labels:
    • Sprint:
      Internationals - 3.8 Sprint 2

      Description

      While working in the calendar, I have noticed the function calendar_get_allowed_event_types is called twice during the proccess to load the calendar event form.

      The first call happens in the fragment calendar_output_fragment_event_form() and then it loads the form class and.. bang, another call.

      The problem is that calendar_get_allowed_event_types() does a lot and it's quite expensive in terms of performance.

        Attachments

          Activity

            People

            Assignee:
            lameze Simey Lameze
            Reporter:
            lameze Simey Lameze
            Peer reviewer:
            Andrew Nicols
            Integrator:
            Adrian Greeve
            Tester:
            CiBoT
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              18/Nov/19

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 hours, 13 minutes
                4h 13m