Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66009

Nested dependency in mod_feedback fails again

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Waiting for peer review
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.5.6, 3.6.4, 3.7
    • Fix Version/s: None
    • Component/s: Feedback
    • Labels:
    • Testing Instructions:
      Hide
      1. Create a feedback with nested dependencies like this:
        Question-1
        Answers: A, B
        Question-2 depends on Question-1 = "A"
        Answers: A, B
        Question-3 depends on Question-1 = "B"
        Answers: A, B
        Question-4 depends on Question-2 = "A"
        Answers: Yes, No
        Question-5 depends on Question-3 = "A"
        Answers: Yes, No
      2. Login as User and complete this feedback
        User Sees Question-1
        Answer is: A
        Sees Question-2
        Answer is A
        Sees Question-4
        Answer is Yes
        Goes back till question-1
        Sees Question-1
        Answer is: B
        Sees Question-3
        Answer is: A
        Sees Question-5
        Answer is: Yes
        (He should not see Question-4)
        Submits his answers
      3. Login as editing teacher and go to the "Show responses" page
        The answer to Question-4 should not be shown.
        On show responses the answer to Question-4 is mistakanly shown.
      Show
      Create a feedback with nested dependencies like this: Question-1 Answers: A, B Question-2 depends on Question-1 = "A" Answers: A, B Question-3 depends on Question-1 = "B" Answers: A, B Question-4 depends on Question-2 = "A" Answers: Yes, No Question-5 depends on Question-3 = "A" Answers: Yes, No Login as User and complete this feedback User Sees Question-1 Answer is: A Sees Question-2 Answer is A Sees Question-4 Answer is Yes Goes back till question-1 Sees Question-1 Answer is: B Sees Question-3 Answer is: A Sees Question-5 Answer is: Yes (He should not see Question-4) Submits his answers Login as editing teacher and go to the "Show responses" page The answer to Question-4 should not be shown. On show responses the answer to Question-4 is mistakanly shown.
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull 3.6 Branch:
    • Pull 3.7 Branch:
    • Pull Master Branch:
      MDL-66009-master

      Description

      If the feedback contains nested dependencies the items are not checked recursively for dependencies in higher levels. This causes wrong results if the user goes back and forth while competing this feedback.

      Steps to reproduce:

      Given:

      ---------------------------------------------

      Question-1
      Answers: A, B

      Question-2 depends on Question-1 = "A"
      Answers: A, B

      Question-3 depends on Question-1 = "B"
      Answers: A, B

      Question-4 depends on Question-2 = "A"
      Answers: Yes, No

      Question-5 depends on Question-3 = "A"
      Answers: Yes, No

      ---------------------------------------------

      The user does the following steps:

      ---------------------------------------------

      Sees Question-1
      Answer is: A

      Sees Question-2
      Answer is A

      Sees Question-4
      Answer is Yes

      Goes back till question-1
      Sees Question-1
      Answer is: B

      Sees Question-3
      Answer is: A

      Sees Question-5
      Answer is: Yes
      (He also mistakenly sees Question-4 because the dependency is solved)

      Submits his answers

      On show responses the answer to Question-4 is mistakanly shown.

      ---------------------------------------------

       

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              grabs Andreas Grabs
              Participants:
              Component watchers:
              Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: