Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66039

Duplicate #page selector attribute with same value

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.6.4, 3.7, 3.8
    • Fix Version/s: 3.6.6, 3.7.2
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Login as any user
      2. Open browser dev tools
      3. Find the div with id "page" (<div id="page" class=.....)
      4. Look through the list of styles and find #page
        1. Verify there is a 50px margin-top applied

      Show
      Login as any user Open browser dev tools Find the div with id "page" ( <div id="page" class=..... ) Look through the list of styles and find #page Verify there is a 50px margin-top applied
    • Affected Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-66039-master

      Description

      With reference to /theme/boost/scss/moodle/drawer.scss there is the selector:

      #page {
          margin-top: $navbar-height;
      }

      which is then defined further down as:

      #page {
          margin-top: $fixed-header-y;
      }

      which overrides it.  However both $navbar-height and $fixed-header-y are the same value because of:

      $fixed-header-y: $navbar-height;

      at the top of the file.

       

       

        Attachments

          Activity

            People

            Assignee:
            basbrands Bas Brands
            Reporter:
            gb2048 Gareth J Barnard
            Peer reviewer:
            Mathew May
            Integrator:
            Andrew Nicols
            Tester:
            Janelle Barcega
            Participants:
            Component watchers:
            Bas Brands
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              9/Sep/19

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 50 minutes
                50m