Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-6605

switch datalib functions (wherever they are now) to use placeholders

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.0
    • None
    • Libraries
    • None
    • Any
    • MOODLE_20_STABLE

      change all the get_records and insert/update/ etc functions to use placeholders.
      invert magic_quotes_gpc hack to stripslashes rather than addslashes
      take away all calls to addslashes

      this was already done once (http://git.catalyst.net.nz/gitweb?p=elgg.git;a=commitdiff;h=553765dbdba08162745fe10710ac20153f3c12d2) but will need to be re-done.

      All calls to *_sql will need to be migrated, although we can retain backwards compatibility by using $values=null in the function definition and only do variable substitution where $values is not empty.

      this DOES break backwards compatibility in a few functinon definitions, see get_records_select in above diff.

            skodak Petr Skoda
            mjollnir Penny Leach (Inactive)
            Nobody Nobody (Inactive)
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.