Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-6605

switch datalib functions (wherever they are now) to use placeholders

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 2.0
    • Libraries
    • None
    • Any
    • MOODLE_20_STABLE

    Description

      change all the get_records and insert/update/ etc functions to use placeholders.
      invert magic_quotes_gpc hack to stripslashes rather than addslashes
      take away all calls to addslashes

      this was already done once (http://git.catalyst.net.nz/gitweb?p=elgg.git;a=commitdiff;h=553765dbdba08162745fe10710ac20153f3c12d2) but will need to be re-done.

      All calls to *_sql will need to be migrated, although we can retain backwards compatibility by using $values=null in the function definition and only do variable substitution where $values is not empty.

      this DOES break backwards compatibility in a few functinon definitions, see get_records_select in above diff.

      Attachments

        Issue Links

          Activity

            People

              skodak Petr Skoda
              mjollnir Penny Leach
              Nobody Nobody
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                24/Nov/10