Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66062

Ensure that travis phpunit tests with php 7.1 are back to pass

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.7.1
    • 3.7, 3.8
    • General, Unit tests
    • MOODLE_37_STABLE, MOODLE_38_STABLE
    • MOODLE_37_STABLE
    • Hide

      1) Verify that travis is passing perfectly for the branches in this issue.

      2) Put it on CiBoT hands to verify that everything continues working (no change in codebase, so nothing should be affected by this).

      Show
      1) Verify that travis is passing perfectly for the branches in this issue. 2) Put it on CiBoT hands to verify that everything continues working (no change in codebase, so nothing should be affected by this).

      With MDL-65249, a new redis-related test was added to verify that, after failing to connect to redis a number of times, the behavior was the expected.

      And it works like a charm!

      But, suddenly, we started to get failures with ALL the travis phpunit runs using php71. Example: https://travis-ci.org/stronk7/moodle/builds/552372633

      Only with travis, and only with php71. Both locally and also CI servers are passing the tests with php71 without any problem.

      So, the only difference, so far, is that the php version of travis, by default (the one coming within their images) uses to be a little bit old. Right now it's exactly 7.1.11.

      And, forcing it to be the current 7.1.30, the tests are back to pass: See https://travis-ci.org/stronk7/moodle/builds/553224011

      So this issue is about to update all the supported branches where we are performing php71 phpunit runs (min/max strategy) and force them to use the, verified to pass, php 7.1.30.

      Note that I've not been trying different versions, neither looked for an issue @ php or redis bug systems. Just tried current 7.1.30, it worked, so good enough.

      Ciao

            stronk7 Eloy Lafuente (stronk7)
            stronk7 Eloy Lafuente (stronk7)
            Victor Déniz Falcón Victor Déniz Falcón
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            CiBoT CiBoT
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 25 minutes
                1h 25m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.