Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66090

Upcoming activities due notification email should come from the support contact

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Integration review in progress
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.7
    • Fix Version/s: None
    • Component/s: Analytics
    • Testing Instructions:
      Hide

      Test this on 37 and master

      Prerequisites

      • Email should be configured so you can receive emails from moodle based on the docs
      • In 'Site Admin' set the following:
        • noreplyaddress to 'noreply@localhost.com'
        • allowedemaildomains to 'localhost.com'

      Test

      1. Log in as admin
      2. Go to site admin > Server > Support contact, and remember the following values
        1. 'supportname' setting (it may be set to Admin User)
        2. 'supportemail' to 'reply@example.com'
      3. Go to site admin > development > Make test course and create a XS course, follow the continue button once done.
      4. Go to participants, a student should appear there.
        1. Make sure 'Insights generated by prediction models' are all turned ON in the notification preferences for this user.
        2. (this is not needed if you use moodle-docker) Replace the student's email address by one you have access to
      5. Edit the assignment activity and set its due date to +6 days from today
      6. Go to site admin > analytics > analytics settings and untick onlycli setting
      7. Go to site admin > analytics > analytics models
      8. If the Upcoming activities due model is disabled click on Actions > Enable for Upcoming activities due model
      9. Click on Actions > Clear predictions for the Upcoming activities due model
      10. Click on Actions > Execute scheduled analysis (or Actions > Get predictions in 3.7) from the Upcoming activities due model
      11. Check the student email. You SHOULD see an email, the "From" should include the value in the 'supportname' setting.
      12. View the email source and confirm the following headers:
        1. From: Admin User <noreply@localhost.com>
        2. ReplyTo: Do not reply to this email <noreply@localhost.com>
      13. In site admin, add 'example.com' to allowedemaildomains
      14. Repeat #6-10
      15. Check the student email. You SHOULD see an email, the "From" should include the value in the 'supportname' setting.
      16. View the email source and confirm the following headers:
        1. From: Admin User <reply@example.com> or Admin User <reply@example.com> (via xxxx) where xxxx is your site name if $CFG->emailfromvia is enabled
        2. ReplyTo: Admin User <reply@example.com>
      Show
      Test this on 37 and master Prerequisites Email should be configured so you can receive emails from moodle based on the docs if you use moodle-docker you can just go to http://localhost:8000/_/mail with $CFG->noemailever = false; Else configure mailcatcher as described here In 'Site Admin' set the following: noreplyaddress to 'noreply@localhost.com' allowedemaildomains to 'localhost.com' Test Log in as admin Go to site admin > Server > Support contact, and remember the following values 'supportname' setting (it may be set to Admin User) 'supportemail' to 'reply@example.com' Go to site admin > development > Make test course and create a XS course, follow the continue button once done. Go to participants, a student should appear there. Make sure ' Insights generated by prediction models ' are all turned ON in the notification preferences for this user. (this is not needed if you use moodle-docker) Replace the student's email address by one you have access to Edit the assignment activity and set its due date to +6 days from today Go to site admin > analytics > analytics settings and untick onlycli setting Go to site admin > analytics > analytics models If the Upcoming activities due model is disabled click on Actions > Enable for Upcoming activities due model Click on Actions > Clear predictions for the Upcoming activities due model Click on Actions > Execute scheduled analysis (or Actions > Get predictions in 3.7) from the Upcoming activities due model Check the student email. You SHOULD see an email, the "From" should include the value in the 'supportname' setting. View the email source and confirm the following headers: From: Admin User <noreply@localhost.com> ReplyTo: Do not reply to this email <noreply@localhost.com> In site admin, add 'example.com' to allowedemaildomains Repeat #6-10 Check the student email. You SHOULD see an email, the "From" should include the value in the 'supportname' setting. View the email source and confirm the following headers: From: Admin User <reply@example.com> or Admin User <reply@example.com> (via xxxx) where xxxx is your site name if $CFG->emailfromvia is enabled ReplyTo: Admin User <reply@example.com>
    • Affected Branches:
      MOODLE_37_STABLE
    • Pull from Repository:
    • Pull 3.6 Branch:
    • Pull 3.7 Branch:
    • Pull Master Branch:
      MDL-66090_master

      Description

      The upcoming activities due notification email is confusing because the from address is 'Do not reply to this email' with no indication of the site.

      Other confusing aspects identified will be fixed in MDL-66091:

      1. The email subject mentions 'activities' whereas the email mentions 'events'.
      2. If you follow the link 'View insight details' it takes you to a page 'Upcoming activities due prediction' which doesn't display any upcoming activities due.
      3. If you follow the link 'Acknowledged' it takes you to your Dashboard where a message is displayed 'Your action has been saved.' with no explanation.
      4. If you follow the link 'Not useful' it also takes you to your Dashboard where a message is displayed 'Your action has been saved.' with no explanation.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 1 minute
                  2h 1m