Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66115

Setting message on ddimageortext if choice not found allows legacy cron to finish

    XMLWordPrintable

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.6.5, 3.7, 3.8
    • Fix Version/s: 3.6.6, 3.7.2
    • Component/s: Questions
    • Labels:
    • Testing Instructions:
      Hide
      1. As an instructor, Create a quiz which uses a qtype_ddimageortext question having at least 3 choices and has several more questions. Set the time limit of the quiz to 1 minute to get attempts expired quickly. Also set the new page setting to "every question" to ensure the attempt will have multiple pages.
      2. As a student, attempt the quiz solving the 3 choice qtype_ddimageortext question but not finishing the attempt, for example, if the other questions are in another page, just change the page, and close the window.
      3. As an instructor, modify the quiz question by removing 1 of the choices
      4. Wait until the quiz expires (1 minute of wait should be enough).
      5. As an admin, run the site cron by running php admin/cli/cron.php. When the unfinished attempt is being considered, you should see the Looking for quiz overdue quiz attempts... string. The output should not show an error when finishing the unfinished attempts, this can be confirmed if Considered X attempts in Y quizzes. appears.
      Show
      As an instructor, Create a quiz which uses a qtype_ddimageortext question having at least 3 choices and has several more questions. Set the time limit of the quiz to 1 minute to get attempts expired quickly. Also set the new page setting to "every question" to ensure the attempt will have multiple pages. As a student, attempt the quiz solving the 3 choice qtype_ddimageortext question but not finishing the attempt, for example, if the other questions are in another page, just change the page, and close the window. As an instructor, modify the quiz question by removing 1 of the choices Wait until the quiz expires (1 minute of wait should be enough). As an admin, run the site cron by running php admin/cli/cron.php . When the unfinished attempt is being considered, you should see the Looking for quiz overdue quiz attempts... string. The output should not show an error when finishing the unfinished attempts, this can be confirmed if  Considered X attempts in Y quizzes. appears.
    • Affected Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull from Repository:
    • Pull 3.6 Branch:
    • Pull 3.7 Branch:
    • Pull Master Branch:
      MDL-66115_master

      Description

      Adding this fix for the bug reported in MDL-66095 which allows the cron job to finish while we get that fix under control.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dvdcastro David Castro
                Reporter:
                dvdcastro David Castro
                Peer reviewer:
                Tim Hunt
                Integrator:
                Eloy Lafuente (stronk7)
                Tester:
                Janelle Barcega
                Participants:
                Component watchers:
                Tim Hunt, Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Sep/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 35 minutes
                  1h 35m