[MDL-66136] Online text assignment error when attempting to submit an image only (with no text) - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.5.7, 3.7
Fix Version/s: 3.5.8, 3.6.6, 3.7.2
Component/s: Assignment
Labels:
- ci
- regression
- release_notes
- triaged

Affected Branches:
MOODLE_35_STABLE, MOODLE_37_STABLE
Fixed Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
Pull from Repository:
git://github.com/mihailges/moodle.git
Pull Master Branch:
~~MDL-66136~~-master
Pull Master Diff URL:
https://github.com/mihailges/moodle/compare/8d9614b341...MDL-66136-master
Testing Instructions:
Hide

Log in as Admin.

Create a Course.

Enrol a Student in the Course.

Create an Assignment activity.

Submission types = "Online text".

Log in as Student.

Go to Course > Assignment.

Add submission.

In the Online text " area, insert only an image using the tool "Insert or edit image".
NOTE: Do not insert any text.

Save changes.

make sure the submission is successfully submitted and you DO NOT see a validation error stating the submission form is empty.

Attempt this scenario by inserting different type of resources (video, audio, recorded video/audio) from the toolbar of the "Online text" submission form.

make sure each time the submission is successfully submitted and you DO NOT see a validation error stating the submission form is empty.
Show
Log in as Admin. Create a Course. Enrol a Student in the Course. Create an Assignment activity. Submission types = "Online text". Log in as Student. Go to Course > Assignment. Add submission. In the Online text " area, insert only an image using the tool "Insert or edit image". NOTE: Do not insert any text. Save changes. make sure the submission is successfully submitted and you DO NOT see a validation error stating the submission form is empty. Attempt this scenario by inserting different type of resources (video, audio, recorded video/audio) from the toolbar of the "Online text" submission form. make sure each time the submission is successfully submitted and you DO NOT see a validation error stating the submission form is empty.

Description

The implementation of ~~MDL-61650~~ "Moodle Assignment online text allows nbs as submission" has caused a regression for teachers who use quick grading.

We have our students submit screenshots of activities they have completed into the assignment module's online text box submission. Students now get an error when submitting that says there is nothing to submit (due to the implementation of ~~MDL-61650~~). I understand the importance of that MDL - to prevent 'blank' submissions from being submitted.

The reason we used the online text for this type of submission is so teachers can utilize the quick grading (it displays all the submission images on one screen instead of requiring teachers to download each file or to grade one visual at a time using the Document Converter Single Student Grading). In the meantime, we're asking our students to type in a letter before or after their inserted screenshot.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

image-2019-07-24-13-32-41-912.png
159 kB
24/Jul/19 1:32 PM

Activity

People

Assignee:: Mihail Geshoski

Reporter:: John Provasnik

Peer reviewer:: Peter Dias

Integrator:: Adrian Greeve

Tester:: Janelle Barcega

Participants:: Adrian Greeve, CiBoT, Janelle Barcega, John Provasnik, Mihail Geshoski, Peter Dias

Component watchers:: Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie

Votes:: 4 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 12/Jul/19 9:29 AM

Updated:: 04/Sep/19 10:36 PM

Resolved:: 25/Jul/19 8:17 PM

Fix Release Date:: 9/Sep/19

Time Tracking

Estimated:

Remaining:

Logged:

5h 40m