Deleting a course that's been starred causes ' invalidrecord: Can't find data record in database table course.' error

Upgrade test. Clone a fresh site, but do not install yet. For each branch, we first need to set up a failure state, based on the latest weekly, so please run the following: For master: git checkout a672f021eaf0 For 37: git checkout 6a30269d98d8 For 36: git checkout 7de0c0f1ad6 Now, as admin, install the site Make sure debugging is set to developer. Create two courses (c1 and c2) and a user (s1) Enrol a user (s1) into c1 and c2 as a student Log out. Log in as s1 view the dashboard Add the 'Starred courses' block and the 'Course overview' block if they're not already present. From the 'Course overview' block, using the ellipsis (...) menu next to the course c1, select 'Star this course'. Do the same for c2. Log out Log in as an admin From site admin -> course management, delete the course c1 Log out Log in as the student s1 Go to the dashboard Verify you see an error popup. This is the bug. Log out Now, checkout the relevant head to trigger the upgrade: For master: git checkout master For 37: git checkout MOODLE_37_STABLE For 36: git checkout MOODLE_36_STABLE Log in as admin and run the upgrade. Log out Log in as the student s1. Go to the dashboard Verify you see no error popup Verify you see c2 listed in the 'Starred courses' block. Course deletion hook test Log in as admin Create a new course c3 and enrol s1 into it as a student Log out Log in as the student s1 Go to the dashboard From the 'Course overview' block, using the ellipsis (...) menu next to the course c3, select 'Star this course'. Log out Log in as admin From site admin -> course management, delete the course c3 Log out Log in as the student s1 Go to the dashboard Verify you see no error popup Verify you don't see the course c3 listed in the 'Starred courses' block. Verify you see c2 listed in the 'Starred courses' block.