Loading...

XML

Word

Printable

Affected Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE
Fixed Branches:
MOODLE_37_STABLE
Pull from Repository:
https://github.com/snake/moodle.git
Pull Main Branch:
~~MDL-66169~~-master
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/6735197cc2ec...snake:MDL-66169-master
Testing Instructions:
Hide

With debugging on:

Ensure that $CFG->debugsmtp is not set in your config.php

Configure outbound mail (mailhog is fine)

Go to the "Test outgoing mail configuration" page

Send a test email to any address

Verify you don't see a php notice on the page.
Show
With debugging on: Ensure that $CFG->debugsmtp is not set in your config.php Configure outbound mail (mailhog is fine) Go to the "Test outgoing mail configuration" page Send a test email to any address Verify you don't see a php notice on the page.

With debugging on:

See the php notice:

Undefined property: stdClass::$debugsmtp

I suspect this is caused by the master-only change made in ~~MDL-60347~~ (making that CFG var optional)

Discovered while testing

MDL-60405 Upgrade Horde library to 5.2.22

is a regression caused by

MDL-60347 SMTP debugging can only provide verbose output (regardless of debugging output level)

Participants:: Andrew Lyons, CiBoT, Eloy Lafuente (stronk7), Jake Dallimore, Janelle Barcega

Estimated:

Not Specified

Remaining:

Logged:

45m