Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66174

Annotate PDF - The width of the stamps menu is too big

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Prerequisites:

      1. A course with a teacher and a student.
      2. An assignment in the course.
      3. Purge the caches

      Testing

      1. Login again as a teacher
      2. Enter the assignment and click the "Grade"button
      3. Click on the "Stamps" button in order to open the stamps dropdown.
      4. Confirm the width of the dropdown is restricted to the width of the stamps contained in it.

      Refer to the screenshots for examples

      Test from 64524

      Note: Test in all themes

      Setup
      1. Purge all caches
      2. Ensure that Ghostscript is installed. (If you open your terminal and enter "which gs", you should see an output showing the path to Ghostscript)
      3. Visit Site administration ▶︎ Server ▶︎ System paths
      4. Ensure 'Path to Ghostscript' points to your Ghostscript executable
      5. Visit Site administration ▶︎ Plugins ▶︎ Activity modules ▶︎ Assignment ▶︎ Feedback plugins ▶︎ Annotate PDF
      6. Click on 'Test Ghostscript path' and confirm it is working
      7. Create an assignment with "Online text" enabled for submissions,  "Annotate PDF" enabled for feedback, and the "Grading method" set to "Marking guide".
      8. Click to view the assignment
      9. For the assignment settings click on "Define marking guide"
      10. Create a new "Marking guide" with several "Frequently used comments" with relatively long texts (Tip: You can use http://www.lipsum.com/)
      11. Grade a student in the assignment.

      Part 1 - Verify the quicklist comments in the pdf editor

      1. Choose the "Comments" tool in the pdf editor. 
      2. Click and drag a comment and write a relatively long comment (or use Lorem Ipsum). 
      3. Hover over the comment with the mouse and click the button to show the menu for the comment.
      4. Add the comment to the "quicklist" several times.
      5. Verify you can see all the comments in the quicklist and once the list got too long you were allowed to scroll.

      Part 2 - Verify the frequently used comments in the marking guide

      1. On the marking guide click the "Insert frequently used comments" button.
      2. Verify you can scroll up or down in the comments dialogue and can choose any of the comments.
         
      Show
      Prerequisites: A course with a teacher and a student. An assignment in the course. Purge the caches Testing Login again as a teacher Enter the assignment and click the "Grade"button Click on the "Stamps" button in order to open the stamps dropdown. Confirm the width of the dropdown is restricted to the width of the stamps contained in it. Refer to the screenshots for examples Test from 64524 Note: Test in all themes Setup Purge all caches Ensure that Ghostscript is installed. (If you open your terminal and enter " which gs ", you should see an output showing the path to Ghostscript) Visit Site administration ▶︎ Server ▶︎ System paths Ensure 'Path to Ghostscript' points to your Ghostscript executable Visit Site administration ▶︎ Plugins ▶︎ Activity modules ▶︎ Assignment ▶︎ Feedback plugins ▶︎ Annotate PDF Click on 'Test Ghostscript path' and confirm it is working Create an assignment with "Online text" enabled for submissions,  "Annotate PDF" enabled for feedback, and the "Grading method" set to "Marking guide". Click to view the assignment For the assignment settings click on "Define marking guide" Create a new "Marking guide" with several "Frequently used comments" with relatively long texts (Tip: You can use http://www.lipsum.com/ ) Grade a student in the assignment. Part 1 - Verify the quicklist comments in the pdf editor Choose the "Comments" tool in the pdf editor.  Click and drag a comment and write a relatively long comment (or use Lorem Ipsum).  Hover over the comment with the mouse and click the button to show the menu for the comment. Add the comment to the "quicklist" several times. Verify you can see all the comments in the quicklist and once the list got too long you were allowed to scroll. Part 2 - Verify the frequently used comments in the marking guide On the marking guide click the "Insert frequently used comments" button. Verify you can scroll up or down in the comments dialogue and can choose any of the comments.  
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull from Repository:
    • Pull 3.6 Branch:
    • Pull 3.7 Branch:
    • Pull Master Branch:
      MDL-66174-master

      Description

      Repro Steps

      1. Login to the Moodle environment
      2. Login as a teacher and create an assignment.
      3. Login as a student and submit a document.
      4. Login again as a teacher, enter the assignment and the submissions table,  and click the "Grade"button at the row of the student that submitted the document.
      5. Click on the "Stamps" button in order to open the stamps dropdown.

       

      Actual Results

      The width of the stamps menu is too big.

       

      Expected Results

      The width of the stamps menu should be smaller, and be asjusted to the width of the stamps.

       

      Problem

      In previous versions of Moodle, the width of the stamps menu was adjusted correctly.

      It seems that taking care of the following bugs created the current issue:

      https://tracker.moodle.org/browse/MDL-65234

      https://tracker.moodle.org/browse/MDL-64524

       

      We know for sure that the same mechanism that controls the width of the stamps menu controls the width of the comments menu - By trying to fix the stamps menu width issue with local CSS manipulation, we created the comment width menu issue, so we had to revert the change and "live" for now with the stamps menu issue.

        Attachments

        1. fail.png
          fail.png
          8 kB
        2. MDL-66174_Boost.jpg
          MDL-66174_Boost.jpg
          79 kB
        3. MDL-66174_Classic.jpg
          MDL-66174_Classic.jpg
          71 kB
        4. MDL-66174_Clean.jpg
          MDL-66174_Clean.jpg
          50 kB
        5. pass.png
          pass.png
          3 kB

          Activity

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Sep/19

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 50 minutes
                2h 50m