-
Bug
-
Resolution: Fixed
-
Minor
-
3.7, 3.7.5
-
MOODLE_37_STABLE
-
MOODLE_37_STABLE, MOODLE_38_STABLE
-
MDL-66200-master_gradebook_csv_import -
Easy
-
In Grade book, While importing a CSV file, if the feedback is set to be ignored and the grades are selected to be imported then all the existing feedback are removed.
Steps to reproduce:
- Create a course with an assignment and participants.
- Grade the students with some feedback comments in Gradebook > Single View tab.
- Export the grade book
- Using "Plain Text Format"
- Include feedback in export
- Import the exported CSV file.
- Click "Upload Grades"
- In "Grade Items Mappings" set
-
- In Identify user by set mapping from "Email address" and mapping to "Email address"
- Under 'Grade items mapping' choose 'Ignore' on feedback
- Set assignment XXX(Real) to corresponding assignment name under Grade items in options
- Upload grades
- Click continue and go back to single view
- See that all the existing Feedback Comments are lost in Single View
After digging around I found that the error is caused in grade_item.php line number 1781 where it tries to compare value of string against a boolean with `!==` operator