Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66248

Core forums - Minor aesthetic fix on portfolio export link

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Note: Test on Boost and Clean

      Pre-conditions
      1. Go to "Site administration / Advanced features"
      2. Enable portfolios and save changes.
      3. Create or use an existing Course with a forum with some discussions
      Test
      1. Go to a discussion in a forum and check the posts in the discussion
      2. Confirm that the "Export to portfolio" link looks nicely aligned and consistent with the rest of the other links before it.
      Show
      Note: Test on Boost and Clean Pre-conditions Go to " Site administration / Advanced features " Enable portfolios and save changes. Create or use an existing Course with a forum with some discussions Test Go to a discussion in a forum and check the posts in the discussion Confirm that the " Export to portfolio " link looks nicely aligned and consistent with the rest of the other links before it.
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.6 Branch:

      Description

      All the commands rendered on a post have the .nav-item .nav-link classes except the portfolio one, which is rendered directly by the portfolio library.

      So the portfolio link looks a bit off without those classes:

      With the classes, the zen returns to the screen:

        Attachments

        1. image-2019-08-20-11-24-45-938.png
          image-2019-08-20-11-24-45-938.png
          79 kB
        2. post-fix.png
          post-fix.png
          27 kB
        3. pre-fix.png
          pre-fix.png
          27 kB

          Activity

            People

            • Votes:
              8 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Sep/19

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours
                3h