Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66262

Add environment check for versions not supporting PHP 7.4

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Note: Testing this issue requires, for some points, a running version of PHP 7.4 (at the time of writing, current version is PHP 7.4rc1).

      Note2: Valid trick, alternatively, if finding a working version is hard... the lib/environmentlib.php file can be edited, after every checkout, replacing the two existing calls to phpversion() by, simply: '7.4.0' (quotes included).

      A) Using PHP 7.1.x - All upgrades work (all supported versions)

      1. Install a Moodle 3.5.x site (MOODLE_35_STABLE)
      2. Upgrade to 3.6.x (MOODLE_36_STABLE)
      3. Upgrade to 3.7.x (MOODLE_37_STABLE)
      4. Upgrade to 3.8dev (master).
      5. Verify that all the upgrades above work without problem.

      B) Using PHP 7.1.x - Upgrades to 36 & 37 with PHP 7.4 don't work

      1. Install a Moodle 3.5.x site (MOODLE_35_STABLE)
      2. Switch to PHP 7.4 (or use the valid trick)
      3. Try to upgrade to 3.6.x (MOODLE_36_STABLE)
      4. Verify that upgrade doesn't work and you get the "PHP version 7.4 is not supported" message.
      5. Try to upgrade to 3.7.x (MOODLE_37_STABLE)
      6. Verify that upgrade doesn't work and you get the "PHP version 7.4 is not supported" message.
      7. Try to upgrade to 3.8dev (master).
      8. Verify that the upgrade works without problem.

      C) Confirm that environment.xml is 100% the same over all branches

      1. Verify that the following git commands return no differences (empty output)

        git diff MOODLE_35_STABLE master -- admin/environment.xml
        git diff MOODLE_36_STABLE master -- admin/environment.xml
        git diff MOODLE_37_STABLE master -- admin/environment.xml
        

      Show
      Note: Testing this issue requires, for some points, a running version of PHP 7.4 (at the time of writing, current version is PHP 7.4rc1). Note2: Valid trick, alternatively, if finding a working version is hard... the lib/environmentlib.php file can be edited, after every checkout, replacing the two existing calls to phpversion() by, simply: '7.4.0' (quotes included). A) Using PHP 7.1.x - All upgrades work (all supported versions) Install a Moodle 3.5.x site (MOODLE_35_STABLE) Upgrade to 3.6.x (MOODLE_36_STABLE) Upgrade to 3.7.x (MOODLE_37_STABLE) Upgrade to 3.8dev (master). Verify that all the upgrades above work without problem. B) Using PHP 7.1.x - Upgrades to 36 & 37 with PHP 7.4 don't work Install a Moodle 3.5.x site (MOODLE_35_STABLE) Switch to PHP 7.4 (or use the valid trick) Try to upgrade to 3.6.x (MOODLE_36_STABLE) Verify that upgrade doesn't work and you get the "PHP version 7.4 is not supported" message. Try to upgrade to 3.7.x (MOODLE_37_STABLE) Verify that upgrade doesn't work and you get the "PHP version 7.4 is not supported" message. Try to upgrade to 3.8dev (master). Verify that the upgrade works without problem. C) Confirm that environment.xml is 100% the same over all branches Verify that the following git commands return no differences (empty output) git diff MOODLE_35_STABLE master -- admin/environment.xml git diff MOODLE_36_STABLE master -- admin/environment.xml git diff MOODLE_37_STABLE master -- admin/environment.xml
    • Affected Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull 3.6 Branch:
    • Pull 3.7 Branch:
    • Pull Master Branch:

      Description

      On Moodle 3.6 and 3.7, add an environmental check about PHP 7.4 not being supported.

      See previous MDL-63421 as reference for this and the behavior in previous branches (3.4 and 3.5).

      Changes are added to all supported versions (security-only included).

      Usual changes to perform to Moodle Docs include (updated to the new PHP 7.4 information):

      • A note in the PHP 7 page about the WIP and the current status, like this.
      • TODO (docs_required) Whenever the new version release notes is available (near release) something like this.

        Attachments

        1. MDL-66262_02.png
          MDL-66262_02.png
          404 kB
        2. MDL-66262_01.png
          MDL-66262_01.png
          339 kB
        3. all_statuses.png
          all_statuses.png
          103 kB

          Issue Links

            Activity

              People

              • Assignee:
                stronk7 Eloy Lafuente (stronk7)
                Reporter:
                stronk7 Eloy Lafuente (stronk7)
                Peer reviewer:
                Andrew Nicols
                Integrator:
                Jun Pataleta
                Tester:
                Jennifer Bauzon
                Participants:
                Component watchers:
                Jake Dallimore, Jun Pataleta, Ryan Wyllie, Matteo Scaramuccia, Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 20 minutes
                  3h 20m