[MDL-66265] Update jshint and add ignore - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.5.7, 3.6.5, 3.7.1, 3.8
Fix Version/s: 3.5.8, 3.6.6, 3.7.2
Component/s: JavaScript
Labels:
- ci
- dev_docs_required

Affected Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
Fixed Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull Master Branch:
~~MDL-66265~~-master
Pull Master Diff URL:
https://github.com/andrewnicols/moodle/compare/d2c0f54cea...MDL-66265-master
Testing Instructions:
Hide

Update your node_modules:

npm install

Run jshint across a large swathe of AMD/ES6 code:

npx jshint lib/amd/src/*.js

(note that, instead of npx you can find jshint under node_modules/.bin/jshint)

Confirm nothing was output (Previously this reported jshint failures)

Run jshint on some of our old YUI modules:

npx jshint --verbose lib/yui/src/actionmenu/js/actionmenu.js

Confirm that the YUI code has some failures (no change)

Run jshint across some old modules:

npx jshint mod/scorm/module.js

Confirm that our old code sucks (no change)
Show
Update your node_modules: npm install Run jshint across a large swathe of AMD/ES6 code: npx jshint lib/amd/src/*.js (note that, instead of npx you can find jshint under node_modules/.bin/jshint ) Confirm nothing was output (Previously this reported jshint failures) Run jshint on some of our old YUI modules: npx jshint --verbose lib/yui/src/actionmenu/js/actionmenu.js Confirm that the YUI code has some failures (no change) Run jshint across some old modules: npx jshint mod/scorm/module.js Confirm that our old code sucks (no change)

Description

I discovered in ~~MDL-66192~~ that jshint is applying to all JS by default, even JS which we expect to be checked by eslint.

We only use jshint for YUI, and it is used intrinsically by Shifter. We can't just replace it with eslint sadly.

We are currently on version 0.9.1 of jshint, which is ancient (7+ years). That version does not support any way to either specify or ignore files.

I propose we upgrade to the latest version of jshint, which does support a .jshintignore and then ignore '*/amd/*'.

Attachments

Issue Links

is blocked by

MDL-66532 Add .nvmrc to ensure it is consistent

Closed

Activity

People

Assignee:: Andrew Lyons

Reporter:: Andrew Lyons

Peer reviewer:: Mathew May

Integrator:: Eloy Lafuente (stronk7)

Tester:: Carlos Escobedo

Participants:: Andrew Lyons, Carlos Escobedo, CiBoT, Eloy Lafuente (stronk7), Jake Dallimore, Mathew May

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 29/Jul/19 9:07 AM

Updated:: 06/Sep/19 12:31 AM

Resolved:: 06/Sep/19 12:31 AM

Fix Release Date:: 9/Sep/19

Time Tracking

Estimated:

Remaining:

Logged:

1w 3d 1h 5m