[MDL-66272] Custom theme favicon on LTI provider site breaks LTI authentication - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.5.7, 3.6.5, 3.7.1
Fix Version/s: 3.6.6, 3.7.2
Component/s: LTI provider, Themes
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
Fixed Branches:
MOODLE_36_STABLE, MOODLE_37_STABLE
Pull from Repository:
git://github.com/vmdef/moodle.git
Pull Master Branch:
~~MDL-66272~~-master
Pull Master Diff URL:
https://github.com/vmdef/moodle/compare/MDL-66272-master~1...MDL-66272-master
Testing Instructions:

Hide

Confirm that the documentation for the favicon method in the class core_renderer (lib/outputrenderers.php) clearly specifies that it returns a moodle_url object.

Show
Confirm that the documentation for the favicon method in the class core_renderer (lib/outputrenderers.php) clearly specifies that it returns a moodle_url object.

Sprint:
Moppies Moodle 3.8 Sprint 4

Description

This report stems from the discussion at https://moodle.org/mod/forum/discuss.php?d=371252

Problem: If a favicon is added through a custom theme setting on the provider site, LTI authentication doesn't work.

A technical description of the issue can be read here: https://moodle.org/mod/forum/discuss.php?d=371252

Attachments

Activity

People

Assignee:: Víctor Déniz Falcón

Reporter:: cb526

Peer reviewer:: Carlos Escobedo

Integrator:: Jun Pataleta

Tester:: Jun Pataleta

Participants:: Carlos Escobedo, cb526, CiBoT, Jun Pataleta, Víctor Déniz Falcón

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Huong Nguyen, Bas Brands, Mathew May

Votes:: 0 Vote for this issue

Watchers:: 8 Start watching this issue

Dates

Created:: 29/Jul/19 10:26 PM

Updated:: 04/Sep/19 10:54 PM

Resolved:: 09/Aug/19 4:54 PM

Fix Release Date:: 9/Sep/19

Time Tracking

Estimated:

0m

Remaining:

0m

Logged:

1h 1m