Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66272

Custom theme favicon on LTI provider site breaks LTI authentication

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Confirm that the documentation for the favicon method in the class core_renderer (lib/outputrenderers.php) clearly specifies that it returns a moodle_url object.

      Show
      Confirm that the documentation for the favicon method in the class core_renderer  (lib/outputrenderers.php) clearly specifies that it returns a moodle_url object.
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-66272-master
    • Pull Master Diff URL:
    • Sprint:
      Moppies Moodle 3.8 Sprint 4

      Description

      This report stems from the discussion at https://moodle.org/mod/forum/discuss.php?d=371252

      Problem: If a favicon is added through a custom theme setting on the provider site, LTI authentication doesn't work. 

      A technical description of the issue can be read here: https://moodle.org/mod/forum/discuss.php?d=371252

       

        Attachments

          Activity

            People

            • Assignee:
              vmdef Víctor Déniz Falcón
              Reporter:
              cb526 cb526
              Peer reviewer:
              Carlos Escobedo
              Integrator:
              Jun Pataleta
              Tester:
              Jun Pataleta
              Participants:
              Component watchers:
              Adrian Greeve, Mihail Geshoski, Peter Dias, Bas Brands, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Sep/19

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 1 minute
                1h 1m