Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66307

Fail to get plugin name for subplugins in babel:dist

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.8
    • Fix Version/s: 3.8
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      Ideally test on both Windows and Linux.

      1. Clone the atto_embedequestion repo

        git clone https://github.com/moodleou/moodle-atto_embedquestion.git lib/editor/atto/plugins/embedquestion
        

      2. Run grunt (requires to have nodejs stuff installed: npm install)

        grunt amd
        

        1. Confirm the build worked correctly and without error
      3. Run grunt watch
      4. Open lib/editor/atto/plugins/embedquestion/amd/src/dialogue_manager.js in your editor
      5. Add some meaningless comment and save changes For example look for "bodyContent" and change it to "bodyTEST"
      6. Remove the file lib/editor/atto/plugins/embedquestion/amd/build/dialogue_manager.min.js
      7. Run grunt watch
        1. Confirm the build worked correctly and without error
        2. Confirm the removed file above has been regenerated.
        3. Confirm it includes the changed "bodyTEST" text.
        4. Confirm it ends with a line like this:
          //# sourceMappingURL=dialogue_manager.min.js.map
      Show
      Ideally test on both Windows and Linux. Clone the atto_embedequestion repo git clone https://github.com/moodleou/moodle-atto_embedquestion.git lib/editor/atto/plugins/embedquestion Run grunt (requires to have nodejs stuff installed: npm install ) grunt amd Confirm the build worked correctly and without error Run grunt watch Open lib/editor/atto/plugins/embedquestion/amd/src/dialogue_manager.js in your editor Add some meaningless comment and save changes For example look for "bodyContent" and change it to "bodyTEST" Remove the file lib/editor/atto/plugins/embedquestion/amd/build/dialogue_manager.min.js Run grunt watch Confirm the build worked correctly and without error Confirm the removed file above has been regenerated. Confirm it includes the changed "bodyTEST" text. Confirm it ends with a line like this: //# sourceMappingURL=dialogue_manager.min.js.map
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull Master Branch:

      Description

      Warning: Unable to find module name for /Users/nicols/Sites/moodles/im/moodle/lib/editor/atto/plugins/embedquestion/amd/src/dialogue_manager.js Use --force to continue.
      

      We made a change to move the subplugin JSON plugintypes to a new location (inside a plugintypes object) but didn't update the babel translator to cope with it.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/19

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 30 minutes
                1h 30m