Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66311

Better handling of action menus in some scenarios added by MDL-58974

    XMLWordPrintable

    Details

      Description

      This is a followup of MDL-58974 where it was detected that some random failures were happening:

      --name 'Evaluate a model'
       
      Moodle 3.8dev (Build: 20190801), 414eca89239d275807f155837e10200f9e81322a
      Php: 7.3.7, pgsql: 9.6.14, OS: Darwin 18.7.0 x86_64
      Server OS "Darwin", Browser: "chrome"
      Browser specific fixes have been applied. See http://docs.moodle.org/dev/Acceptance_testing#Browser_specific_fixes
      Started at 02-08-2019, 05:56
      ..................................................F-----------------
       
      --- Pasos fallidos:
       
      001 Scenario: Evaluate a model                                         # /Users/stronk7/git_moodle/moodle/analytics/tests/behat/manage_models.feature:66
            And I click on "[title='View prediction details']" "css_element" # /Users/stronk7/git_moodle/moodle/analytics/tests/behat/manage_models.feature:116
              The "(//html/descendant-or-self::*[@title = 'View prediction details'])[1]" xpath node is not visible and it should be visible (Behat\Mink\Exception\ExpectationException)
       
      1 escenario (1 fallaron)
      68 pasos (50 pasaron, 1 fallaron, 17 saltadas)
      1m11.98s (86.01Mb)
      

      Performing this simple change to the special "action menu" steps seems to solve the problem:

      index 8a668c924fd..f6a22692e20 100644
      --- a/analytics/tests/behat/manage_models.feature
      +++ b/analytics/tests/behat/manage_models.feature
      @@ -112,8 +112,8 @@ Feature: Manage analytics models
           # View predictions
           When I select "C3" from the "contextid" singleselect
           #And I click on "#dropdown-3" "css_element"
      -    And I click on "Actions" "link" in the "Student 6" "table_row"
      -    And I click on "View prediction details" "link"
      +    And I open the action menu in "Student 6" "table_row"
      +    And I choose "View prediction details" in the open action menu
           And I should see "Prediction details"
           And I should see "Any write action"
           And I should see "Read actions amount"
      

      This issue is about to change as many of the uses to use the specialised steps in all the places where they can be used instead of the "click" variants.

      And, of course, ensure that the tests are passing consistently.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              vmdef Víctor Déniz Falcón
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Peer reviewer:
              David Monllaó
              Integrator:
              Adrian Greeve
              Tester:
              CiBoT
              Participants:
              Component watchers:
              Elizabeth Dalton, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 45 minutes
                  3h 45m