[MDL-66328] Groups overview runs out of memory on very large courses - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.6.5, 3.7.1
Fix Version/s: 3.6.7, 3.7.3
Component/s: Groups
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_36_STABLE, MOODLE_37_STABLE
Fixed Branches:
MOODLE_36_STABLE, MOODLE_37_STABLE
Pull from Repository:
https://github.com/timhunt/moodle.git
Pull Main Branch:
~~MDL-66328~~
Pull Main Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-66328
Testing Instructions:
Hide

Use Admin -> Development -> Make test course to generate an XL or XXL course.

Ensure that Admin -> Development -> Debugging -> Show performance info is turned on.

Go to Course setting -> Users -> Groups -> Groups overview.

Verify that the page displays (rather than an out-of-memory error).
Show
Use Admin -> Development -> Make test course to generate an XL or XXL course. Ensure that Admin -> Development -> Debugging -> Show performance info is turned on. Go to Course setting -> Users -> Groups -> Groups overview. Verify that the page displays (rather than an out-of-memory error).

Description

The groups overview is running out of memory on one of our very large courses.

I think that is mostly caused by ~~MDL-66327~~ which will be helped by changing the $nogroupusers = $DB->get_records_sql($sql, $params); line to a get_recordset.

Also, since this is a large report, it might be reasonable to allow it MEMORY_EXTRA.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-66328.png
53 kB
11/Sep/19 3:24 PM

Issue Links

has a non-specific relationship to

MDL-66327 $DB->get_records uses a lot of Peak RAM (with Postgres)

Closed

Activity

People

Assignee:: Tim Hunt

Reporter:: Tim Hunt

Peer reviewer:: Sam Marshall

Integrator:: Andrew Lyons

Tester:: Jennifer Bauzon

Participants:: Andrew Lyons, CiBoT, Jennifer Bauzon, Sam Marshall, Tim Hunt

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 06/Aug/19 12:07 AM

Updated:: 05/Nov/19 6:20 PM

Resolved:: 13/Sep/19 11:53 AM

Fix Release Date:: 11/Nov/19

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

2h 10m