Loading...

XML

Word

Printable

Details

Type: Improvement
Resolution: Fixed
Priority: Minor
Fix Version/s: 3.5.9, 3.6.7, 3.7.3
Affects Version/s: 3.5.6, 3.6.5, 3.7.1, 3.8
Component/s: Automated functional tests (behat)
Labels:

Affected Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
Fixed Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
Pull from Repository:
https://github.com/timhunt/moodle.git
Pull Main Branch:
~~MDL-66335~~
Pull Main Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-66335
Testing Instructions:
Hide

This change only affects Behat, except for a small change in login.php which should only have effect for Behat test sites. We just need a small manual check to verify that does not cause regressions:

Verify that you can log in to your Moodle site without getting an error.
Show
This change only affects Behat, except for a small change in login.php which should only have effect for Behat test sites. We just need a small manual check to verify that does not cause regressions: Verify that you can log in to your Moodle site without getting an error.

Description

There are now quite a lot of different Behat steps in differen core components and plugins, along the lines of

And I am on "..." ...

This is all very well but it is quite a lot of duplicate code.

I think it would be better to have a single step like

And I am on "mod_forum" "Automated testing" "discussion page"

This step would work by getting the behat_mod_forum context, and then calling ->resolve_url("discussion page", "Automated testing"), then navigating to that URL.

Attachments

Issue Links

has a non-specific relationship to

MDL-48024 Plugins should be able to provide data generators for Behat

Closed

MDL-65600 Plugin should be able to define named selectors for Behat tests

Closed

has been marked as being related by

MDL-66559 Components should be able to define their own named selectors

Closed

is duplicated by

MDL-66093 The Dashboard makes every Behat test very very slow for @javascript tests

Closed

will help resolve

MDL-66093 The Dashboard makes every Behat test very very slow for @javascript tests

Closed

Activity

People

Assignee:: Tim Hunt

Reporter:: Tim Hunt

Peer reviewer:: Sam Marshall

Integrator:: Eloy Lafuente (stronk7)

Tester:: CiBoT

Participants:: Andrew Lyons, CiBoT, Eloy Lafuente (stronk7), Sam Marshall, Tim Hunt

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 07/Aug/19 6:45 PM

Updated:: 13/Sep/22 4:03 PM

Resolved:: 16/Oct/19 5:21 AM

Fix Release Date:: 11/Nov/19

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

1d 6h